[Merged by Bors] - Added boa examples #1161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RageKnify
requested changes
Mar 8, 2021
RageKnify
requested changes
Mar 8, 2021
RageKnify
reviewed
Apr 5, 2021
|
Hello @jasonwilliams how is this going? |
|
OK, from what i remember it was just the change @RageKnify pointed out. |
|
I have updated the most simple examples, but the rest require some extra work. |
Test262 conformance changesVM implementation
|
Benchmark for 84abeccClick to view benchmark
|
Benchmark for 6cfef13Click to view benchmark
|
jedel1043
reviewed
Oct 13, 2021
jasonwilliams
force-pushed
the
examples
branch
from
d4c5e94
to
785307d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1161 +/- ##
==========================================
- Coverage 46.59% 46.58% -0.01%
==========================================
Files 205 206 +1
Lines 16753 16781 +28
==========================================
+ Hits 7806 7818 +12
- Misses 8947 8963 +16
Continue to review full report at Codecov.
|
RageKnify
approved these changes
Nov 11, 2021
Razican
reviewed
Nov 13, 2021
There was a problem hiding this comment.
Looks good to me, I think these examples will be useful for our users. The only thing I'm missing is a small description on the top of each example with module level comments (//!) explaining what the example is supposed to do.
Also, I would say we don't have an example that changes the global object, right? Do we want to have this? Is it possible with the current API?
How do you mean change the global object? Do you mean to add properties to it? |
I meant using "window" as a global object for example, but I guess that's just an alias, right? And then adding some attributes to it. |
|
@jasonwilliams do you think we could have this ready for 0.14? It would be nice to have new examples here. |
jasonwilliams
force-pushed
the
examples
branch
from
2c33e14
to
74014a5
Compare
Benchmark for 7a68787Click to view benchmark
|
|
I will look at this during the week, I would love to merge it asap :) |
Benchmark for be7b626Click to view benchmark
|
Added boa examples as per issue #446
* spelling mistake * Rust FMT
Benchmark for dab5b4cClick to view benchmark
|
|
|
Benchmark for 109c2d7Click to view benchmark
|
This is due to the way deriving works for that crate. Maybe it can be fixed with a PR to the gc crate |
Benchmark for 13117ebClick to view benchmark
|
|
@jedel1043 you happy with this? |
jedel1043
approved these changes
Mar 8, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
Added boa examples as per issue #446 Overtaken #634 Somehow screwed that branch up by rebasing it and losing access pings @elasmojs This Pull Request fixes/closes #446 . Co-authored-by: Jason Williams <jase.williams@gmail.com> Co-authored-by: Iban Eguia (Razican) <razican@protonmail.ch> Co-authored-by: jasonwilliams <jase.williams@gmail.com> Co-authored-by: jedel1043 <jedel0124@gmail.com>
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added boa examples as per issue #446
Overtaken #634
Somehow screwed that branch up by rebasing it and losing access
pings @elasmojs
This Pull Request fixes/closes #446 .