Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using upstream benchmark action #1753

Merged
merged 2 commits into from
Dec 31, 2021
Merged

Using upstream benchmark action #1753

merged 2 commits into from
Dec 31, 2021

Conversation

Razican
Copy link
Member

@Razican Razican commented Dec 19, 2021

This Pull Request stops using our GitHub action fork, and starts using the upstream GitHub action for benchmarks. This follows this example:
https://github.com/benchmark-action/github-action-benchmark/tree/master/examples/criterion-rs

This is blocked, though, until benchmark-action/github-action-benchmark#94 gets merged, since our benchmarks have spaces in their names.

@Razican Razican added dependencies Pull requests that update a dependency file blocked Waiting for another code change benchmark Issues and PRs related to the benchmark subsystem. labels Dec 19, 2021
@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #1753 (43749d0) into main (dfb3df5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1753   +/-   ##
=======================================
  Coverage   56.30%   56.30%           
=======================================
  Files         200      200           
  Lines       17049    17049           
=======================================
  Hits         9599     9599           
  Misses       7450     7450           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfb3df5...43749d0. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 19, 2021

Test262 conformance changes

VM implementation

Test result main count PR count difference
Total 87,200 87,200 0
Passed 40,782 40,782 0
Ignored 19,493 19,493 0
Failed 26,925 26,925 0
Panics 0 0 0
Conformance 46.77% 46.77% 0.00%

@jasonwilliams
Copy link
Member

I would also like to keep this un hold until the non-vm branch is in, as ive had to make changes there too and this would conflict

@jasonwilliams
Copy link
Member

What is the 5th one down on here?
https://boa-dev.github.io/boa/dev/bench/

@Razican
Copy link
Member Author

Razican commented Dec 21, 2021

What is the 5th one down on here?

https://boa-dev.github.io/boa/dev/bench/

That's a good question. It appears there since forever, but I have not been able to find why or where it's coming from (didn't spend much time on it either).

It's either a display issue or a data issue, of course.

@Razican
Copy link
Member Author

Razican commented Dec 29, 2021

Our PR was merged, and I updated the action version, so this is now ready for review.

@jasonwilliams
Copy link
Member

LGTM but hope you can check it’s compatible on the first build

@Razican
Copy link
Member Author

Razican commented Dec 31, 2021

bors r+

@bors
Copy link

bors bot commented Dec 31, 2021

👎 Rejected by label

@Razican Razican removed the blocked Waiting for another code change label Dec 31, 2021
@Razican
Copy link
Member Author

Razican commented Dec 31, 2021

bors retry

@bors
Copy link

bors bot commented Dec 31, 2021

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@Razican Razican merged commit 50dda0b into main Dec 31, 2021
@bors bors bot deleted the better_benches branch December 31, 2021 13:11
@bors
Copy link

bors bot commented Dec 31, 2021

Stopped waiting for PR status (Github check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests.

@Razican Razican added this to the v0.14.0 milestone Feb 23, 2022
@RageKnify RageKnify added the Internal Category for changelog label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. dependencies Pull requests that update a dependency file Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants