-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using upstream benchmark action #1753
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1753 +/- ##
=======================================
Coverage 56.30% 56.30%
=======================================
Files 200 200
Lines 17049 17049
=======================================
Hits 9599 9599
Misses 7450 7450 Continue to review full report at Codecov.
|
Test262 conformance changesVM implementation
|
I would also like to keep this un hold until the non-vm branch is in, as ive had to make changes there too and this would conflict |
What is the 5th one down on here? |
That's a good question. It appears there since forever, but I have not been able to find why or where it's coming from (didn't spend much time on it either). It's either a display issue or a data issue, of course. |
12b3b25
to
43749d0
Compare
Our PR was merged, and I updated the action version, so this is now ready for review. |
LGTM but hope you can check it’s compatible on the first build |
bors r+ |
👎 Rejected by label |
bors retry |
🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
Stopped waiting for PR status (Github check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests. |
This Pull Request stops using our GitHub action fork, and starts using the upstream GitHub action for benchmarks. This follows this example:
https://github.com/benchmark-action/github-action-benchmark/tree/master/examples/criterion-rs
This is blocked, though, until benchmark-action/github-action-benchmark#94 gets merged, since our benchmarks have spaces in their names.