-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arguments
and eval
in the return position of strict functions
#1836
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1836 +/- ##
=======================================
Coverage 55.71% 55.72%
=======================================
Files 201 201
Lines 17326 17336 +10
=======================================
+ Hits 9654 9661 +7
- Misses 7672 7675 +3
Continue to review full report at Codecov.
|
VM implementation
Fixed tests (26):
Broken tests (67):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking pretty good to me, but somehow it's failing a bunch of tests :/
arguments
and eval
in the return position of strict functions
@am-a-man could you check if those failing tests can be fixed? Also, this would need a re-base. |
I took at a look at the failing tests. They are failing because they are no longer returning a SyntaxError. @am-a-man Are you planning on fixing the regressions? |
@lupd I'll look into it, although it could take some time, sorry for the delay but it could still take some time due to university exams going on. I'll look into it as soon as I get some time. |
Fixed by #2069 |
This Pull Request fixes/closes #1598 .
It changes the following:
STRICT_FORBIDDEN_IDENTIFIERS
LexicalBinding
to throw Error when assigning toeval
orarguments
in strict modeVariableDeclaration
to throw Error when assigning toeval
orarguments
in strict mode