[Merged by Bors] - Remove strict flag from Context
#2069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskad
added
enhancement
raskad
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify and
jedel1043
Test262 conformance changesVM implementation
Fixed tests (267):Broken tests (13): |
Codecov Report
@@ Coverage Diff @@
## main #2069 +/- ##
==========================================
- Coverage 44.17% 43.80% -0.37%
==========================================
Files 216 216
Lines 19383 19543 +160
==========================================
- Hits 8562 8561 -1
- Misses 10821 10982 +161
Continue to review full report at Codecov.
|
Benchmark for 8f850b3Click to view benchmark
|
jedel1043
reviewed
May 21, 2022
jedel1043
requested changes
May 21, 2022
|
I suppose the new failing errors are cases where the tests passed because of missing features or so? |
Exactly. I have a fix for those in the pipeline together with some other fixes. |
Nice! Let's merge this then :) |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 21, 2022
The `Context` currently contains a `strict` flag that indicates is global strict mode is active. This is redundant to the strict flag that is set on every function and causes some non spec compliant situations. This pull request removes the strict flag from `Context` and fixes some resulting errors. Detailed changes: - Remove strict flag from `Context` - Make 262 tester compliant with the strict section in [test262/INTERPRETING.md](https://github.com/tc39/test262/blob/2e7cdfbe18eae4309677033673bb4b5ac6b1de40/INTERPRETING.md#strict-mode) - Make 262 tester compliant with the `raw` flag in [test262/INTERPRETING.md](https://github.com/tc39/test262/blob/2e7cdfbe18eae4309677033673bb4b5ac6b1de40/INTERPRETING.md#flags) - Allow function declarations in strict mode - Fix parser flag propagation for classes - Move some early errors from the lexer to the parser - Add / fix some early errors for 'arguments' and 'eval' identifier usage in strict mode - Refactor `ArrayLiteral` parser for readability and correct early errors
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
strict flag from Contextstrict flag from Context
Benchmark for e1b7c57Click to view benchmark
|
Razican
pushed a commit
that referenced
this pull request
Jun 8, 2022
The `Context` currently contains a `strict` flag that indicates is global strict mode is active. This is redundant to the strict flag that is set on every function and causes some non spec compliant situations. This pull request removes the strict flag from `Context` and fixes some resulting errors. Detailed changes: - Remove strict flag from `Context` - Make 262 tester compliant with the strict section in [test262/INTERPRETING.md](https://github.com/tc39/test262/blob/2e7cdfbe18eae4309677033673bb4b5ac6b1de40/INTERPRETING.md#strict-mode) - Make 262 tester compliant with the `raw` flag in [test262/INTERPRETING.md](https://github.com/tc39/test262/blob/2e7cdfbe18eae4309677033673bb4b5ac6b1de40/INTERPRETING.md#flags) - Allow function declarations in strict mode - Fix parser flag propagation for classes - Move some early errors from the lexer to the parser - Add / fix some early errors for 'arguments' and 'eval' identifier usage in strict mode - Refactor `ArrayLiteral` parser for readability and correct early errors
This was referenced Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Contextcurrently contains astrictflag that indicates is global strict mode is active. This is redundant to the strict flag that is set on every function and causes some non spec compliant situations. This pull request removes the strict flag fromContextand fixes some resulting errors.Detailed changes:
Contextrawflag in test262/INTERPRETING.mdArrayLiteralparser for readability and correct early errors