Make missing break labels not panic #1859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addisoncrump
force-pushed
the
break-labels
branch
from
2802b98
to
c1ce48e
Compare
addisoncrump
force-pushed
the
break-labels
branch
from
c1ce48e
to
9a274d9
Compare
Codecov Report
@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
- Coverage 56.29% 56.29% -0.01%
==========================================
Files 201 201
Lines 17936 17937 +1
==========================================
Hits 10097 10097
- Misses 7839 7840 +1
Continue to review full report at Codecov.
|
Razican
approved these changes
Feb 23, 2022
| break nonexistent; | ||
| } | ||
| "#; | ||
|
|
||
| let _ = &exec(src); | ||
| assert!(matches!(Context::default().eval(src.as_bytes()), Err(_))); |
There was a problem hiding this comment.
Could this be changed to assert!(Context::default().eval(&src).is_err())?
It seems simpler :)
raskad
approved these changes
Feb 23, 2022
|
This has been fixed by #1874 , so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the following: