Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add From<f32> for JsValue #1990

Closed
wants to merge 1 commit into from

Conversation

lastmjs
Copy link
Contributor

@lastmjs lastmjs commented Mar 30, 2022

This Pull Request fixes/closes #1989.

It changes the following:

  • Implements From for JsValue

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #1990 (36113ff) into main (c23d32b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
- Coverage   45.90%   45.89%   -0.01%     
==========================================
  Files         206      206              
  Lines       17148    17150       +2     
==========================================
  Hits         7871     7871              
- Misses       9277     9279       +2     
Impacted Files Coverage Δ
boa_engine/src/value/conversions.rs 25.00% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c23d32b...36113ff. Read the comment docs.

@jedel1043 jedel1043 added enhancement New feature or request API labels Mar 31, 2022
@jedel1043 jedel1043 added this to the v0.15.0 milestone Mar 31, 2022
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@raskad
Copy link
Member

raskad commented Apr 2, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 2, 2022
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel neccesary.
--->

This Pull Request fixes/closes #1989.

It changes the following:

- Implements From<f32> for JsValue
@bors
Copy link

bors bot commented Apr 2, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add From<f32> for JsValue [Merged by Bors] - Add From<f32> for JsValue Apr 2, 2022
@bors bors bot closed this Apr 2, 2022
Razican pushed a commit that referenced this pull request Jun 8, 2022
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel neccesary.
--->

This Pull Request fixes/closes #1989.

It changes the following:

- Implements From<f32> for JsValue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement From<f32> for JsValue
3 participants