[Merged by Bors] - Remove string-interner dependency and implement custom string Interner
#2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
dependencies
jedel1043
force-pushed
the
custom-interner
branch
from
a33e8aa
to
28f9272
Compare
jedel1043
force-pushed
the
custom-interner
branch
from
28f9272
to
4958d0f
Compare
jedel1043
removed
the
benchmark
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #2147 +/- ##
==========================================
+ Coverage 42.68% 42.71% +0.02%
==========================================
Files 222 225 +3
Lines 20763 20791 +28
==========================================
+ Hits 8863 8881 +18
- Misses 11900 11910 +10
Continue to review full report at Codecov.
|
Benchmark for cb3dc61Click to view benchmark
|
Benchmark for 234d628Click to view benchmark
|
Razican
approved these changes
Jun 28, 2022
raskad
reviewed
Jun 28, 2022
Essentially I've inlined the However, I'm expecting the most important improvement will come with the implementation of |
Benchmark for ef932a1Click to view benchmark
|
Benchmark for b1f06a6Click to view benchmark
|
raskad
approved these changes
Jun 28, 2022
Razican
reviewed
Jun 29, 2022
jedel1043
force-pushed
the
custom-interner
branch
from
ccea232
to
7fb8d9d
Compare
Benchmark for a24b823Click to view benchmark
|
Benchmark for 75c2a77Click to view benchmark
|
Razican
reviewed
Jun 30, 2022
jedel1043
force-pushed
the
custom-interner
branch
from
7fb8d9d
to
0c2ef02
Compare
Razican
approved these changes
Jun 30, 2022
|
@Razican fixed! |
Benchmark for 86598bdClick to view benchmark
|
Benchmark for d1774c3Click to view benchmark
|
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
…rner` (#2147) So, @raskad and myself had a short discussion about the state of #736, and we came to the conclusion that it would be a good time to implement our own string interner; partly because the `string-interner` crate is a bit unmaintained (as shown by Robbepop/string-interner#42 and Robbepop/string-interner#47), and partly because it would be hard to experiment with custom optimizations for UTF-16 strings. I still want to thank @Robbepop for the original implementation though, because some parts of this design have been shamelessly stolen from it 😅. Having said that, this PR is a complete reimplementation of the interner, but with some modifications to (hopefully!) make it a bit easier to experiment with UTF-16 strings, apply optimizations, and whatnot :)
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
string-interner dependency and implement custom string Internerstring-interner dependency and implement custom string Interner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, @raskad and myself had a short discussion about the state of #736, and we came to the conclusion that it would be a good time to implement our own string interner; partly because the
string-internercrate is a bit unmaintained (as shown by Robbepop/string-interner#42 and Robbepop/string-interner#47), and partly because it would be hard to experiment with custom optimizations for UTF-16 strings. I still want to thank @Robbepop for the original implementation though, because some parts of this design have been shamelessly stolen from it 😅.Having said that, this PR is a complete reimplementation of the interner, but with some modifications to (hopefully!) make it a bit easier to experiment with UTF-16 strings, apply optimizations, and whatnot :)