[Merged by Bors] - Split Node into Statement, Expression and Declaration
#2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
parser
Test262 conformance changesVM implementation
Fixed tests (148):Broken tests (1): |
Codecov Report
@@ Coverage Diff @@
## main #2319 +/- ##
==========================================
- Coverage 40.68% 40.14% -0.55%
==========================================
Files 241 241
Lines 22811 22966 +155
==========================================
- Hits 9281 9219 -62
- Misses 13530 13747 +217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Benchmark for e04c7d0Click to view benchmark
|
raskad
approved these changes
Oct 1, 2022
Benchmark for 2e66299Click to view benchmark
|
Razican
reviewed
Oct 2, 2022
There was a problem hiding this comment.
Impressive work! This is a great addition. I still didn't have the time to look over everything (150 files left :O) But it's looking very good.
I'd like to have your thoughts about boxing all expressions. It makes sense from a space perspective, but might be less efficient. It might make sense to box them at the Node level only.
jedel1043
force-pushed
the
stmt-expr-split
branch
from
7260aa4
to
b934346
Compare
Benchmark for e8bd7d3Click to view benchmark
|
jedel1043
force-pushed
the
stmt-expr-split
branch
from
b934346
to
8542913
Compare
Benchmark for 76a0d2bClick to view benchmark
|
jedel1043
force-pushed
the
stmt-expr-split
branch
from
8542913
to
34b00b0
Compare
Benchmark for d63a871Click to view benchmark
|
jedel1043
changed the title
Node into Statement and ExpressionNode into Statement, Expression and Declaration
|
Had to split |
Benchmark for ab9193aClick to view benchmark
|
Benchmark for 8d25bf6Click to view benchmark
|
jedel1043
force-pushed
the
stmt-expr-split
branch
from
67ccd78
to
bb101f7
Compare
Benchmark for 4c72bdaClick to view benchmark
|
RageKnify
approved these changes
Oct 16, 2022
|
This is missing a lot of documentation, but I'll merge this as it is, since the number of changes is pretty massive and I wouldn't like to add more changes on top of that. I'll follow up with two PRs that implement bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2022
This Pull Request fixes #1371. And yeah, the number of file changes is real... It changes the following: - Split the ast `Node` into `Statement` and `Expression`. - Rewrite the parser and bytecompiler to conform to this change. - Refactor some ast nodes into reusable structures. - Rewrite `contains_arguments` and `contains` to ease the transition into a future ast visitor. List of things that were apparently fixed by this refactor?: - Implement read-assign operation for private accessors (e.g. `this.#field ||= 5`). - `var await` declaration now allowed outside `async` functions and inside functions nested in async functions. - Reject redeclarations of variables declared in the init list of a for loop. Still missing some documentation adjustments, will try to do it ASAP.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Node into Statement, Expression and DeclarationNode into Statement, Expression and Declaration
bors bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
As promised in #2319 (comment). There are still some style inconsistencies (which require a bit more time and effort), but having the whole module documented is a lot better for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes #1371. And yeah, the number of file changes is real...
It changes the following:
NodeintoStatementandExpression.contains_argumentsandcontainsto ease the transition into a future ast visitor.List of things that were apparently fixed by this refactor?:
this.#field ||= 5).var awaitdeclaration now allowed outsideasyncfunctions and inside functions nested in async functions.Still missing some documentation adjustments, will try to do it ASAP.