Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Document the AST #2377

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Document the AST #2377

wants to merge 3 commits into from

Conversation

jedel1043
Copy link
Member

As promised in #2319 (comment). There are still some style inconsistencies (which require a bit more time and effort), but having the whole module documented is a lot better for clarity.

@jedel1043 jedel1043 added documentation update documentation ast Issue surrounding the abstract syntax tree labels Oct 24, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Oct 24, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,789 93,789 0
Passed 69,150 69,150 0
Ignored 18,352 18,352 0
Failed 6,287 6,287 0
Panics 0 0 0
Conformance 73.73% 73.73% 0.00%

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #2377 (94b13c3) into main (48e6513) will decrease coverage by 0.00%.
The diff coverage is 28.96%.

@@            Coverage Diff             @@
##             main    #2377      +/-   ##
==========================================
- Coverage   39.89%   39.88%   -0.01%     
==========================================
  Files         304      304              
  Lines       23332    23317      -15     
==========================================
- Hits         9308     9300       -8     
+ Misses      14024    14017       -7     
Impacted Files Coverage Δ
boa_engine/src/lib.rs 82.14% <ø> (ø)
boa_engine/src/syntax/ast/declaration/mod.rs 75.75% <ø> (ø)
boa_engine/src/syntax/ast/declaration/variable.rs 39.34% <ø> (ø)
boa_engine/src/syntax/ast/expression/access.rs 21.31% <ø> (ø)
boa_engine/src/syntax/ast/expression/identifier.rs 15.78% <ø> (ø)
...gine/src/syntax/ast/expression/literal/template.rs 12.00% <ø> (ø)
boa_engine/src/syntax/ast/expression/mod.rs 40.29% <ø> (ø)
boa_engine/src/syntax/ast/expression/new.rs 14.28% <0.00%> (ø)
.../src/syntax/ast/expression/operator/conditional.rs 44.00% <0.00%> (ø)
...ngine/src/syntax/ast/expression/tagged_template.rs 36.00% <ø> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good work!! Thank you so much.

I have added some comments, let me know what you think :)

boa_engine/src/syntax/ast/expression/spread.rs Outdated Show resolved Hide resolved
boa_engine/src/syntax/ast/expression/spread.rs Outdated Show resolved Hide resolved
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! :)

@Razican
Copy link
Member

Razican commented Oct 25, 2022

Bors r+

@bors
Copy link

bors bot commented Oct 25, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@jedel1043
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2022
As promised in #2319 (comment). There are still some style inconsistencies (which require a bit more time and effort), but having the whole module documented is a lot better for clarity.
@bors
Copy link

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Document the AST [Merged by Bors] - Document the AST Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
@bors bors bot deleted the ast-docs branch October 26, 2022 00:39
@RageKnify RageKnify added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Issue surrounding the abstract syntax tree documentation update documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants