Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider strict + no-strict tests as a single test #3675

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

jedel1043
Copy link
Member

A simplified version of #3364 that only fixes the conformance representation without doing anything else. Thanks to this, it should be completely retrocompatible with previous runs.

@jedel1043 jedel1043 added bug Something isn't working test Issues and PRs related to the tests. labels Feb 15, 2024
@jedel1043 jedel1043 added this to the v0.18.0 milestone Feb 15, 2024
@jedel1043 jedel1043 requested a review from a team February 15, 2024 19:01
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 96,544 50,268 -46,276
Passed 81,283 42,549 -38,734
Ignored 3,039 1,570 -1,469
Failed 12,222 6,149 -6,073
Panics 0 0 0
Conformance 84.19% 84.64% +0.45%

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! :)

@HalidOdat HalidOdat requested a review from a team February 16, 2024 13:13
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nekevss nekevss added this pull request to the merge queue Feb 16, 2024
Merged via the queue into main with commit 9109491 Feb 16, 2024
13 checks passed
@nekevss nekevss deleted the fix-test-eval branch February 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants