Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for symbols as property keys for Object.defineProperty #770

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Support for symbols as property keys for Object.defineProperty #770

merged 3 commits into from
Oct 3, 2020

Conversation

georgeroman
Copy link
Contributor

Fixes #732

@codecov
Copy link

codecov bot commented Oct 2, 2020 •
edited
Loading

Codecov Report

Merging #770 into master will increase coverage by 0.17%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   58.51%   58.68%   +0.17%     
==========================================
  Files         152      152              
  Lines        9476     9477       +1     
==========================================
+ Hits         5545     5562      +17     
+ Misses       3931     3915      -16
Impacted Files Coverage Δ
boa/src/builtins/object/mod.rs 55.88% <50.00%> (+5.38%) ⬆️
boa/src/property/mod.rs 57.34% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb8c94...d8eb153. Read the comment docs.

HalidOdat
HalidOdat reviewed Oct 2, 2020
View reviewed changes
boa/src/property/mod.rs Outdated Show resolved Hide resolved
@georgeroman
Copy link
Contributor Author

Addressed the comments.

@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Oct 2, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 2, 2020
@HalidOdat HalidOdat changed the title Add support for symbols as property keys for objects Support for symbols as property keys for Object.defineProperty Oct 3, 2020
@HalidOdat HalidOdat merged commit 31e3174 into boa-dev:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.

Symbols cannot be defined as a property
2 participants
@georgeroman @HalidOdat