Support for symbols as property keys for Object.defineProperty

boa/src/builtins/object/mod.rs

@@ -16,7 +16,7 @@
 use crate::{
     builtins::function::{make_builtin_fn, make_constructor_fn},
     object::{Object as BuiltinObject, ObjectData},
-    property::Property,
+    property::{Property, PropertyKey},
     value::{same_value, Value},
     BoaProfiler, Context, Result,
 };
@@ -96,9 +96,9 @@ impl Object {
     }
 
     /// Define a property in an object
-    pub fn define_property(_: &Value, args: &[Value], ctx: &mut Context) -> Result<Value> {
+    pub fn define_property(_: &Value, args: &[Value], _ctx: &mut Context) -> Result<Value> {
         let obj = args.get(0).expect("Cannot get object");
-        let prop = args.get(1).expect("Cannot get object").to_string(ctx)?;
+        let prop = PropertyKey::from(args.get(1).expect("Cannot get object"));
         let desc = Property::from(args.get(2).expect("Cannot get object"));
         obj.set_property(prop, desc);
         Ok(Value::undefined())

boa/src/builtins/object/tests.rs

@@ -177,3 +177,17 @@ fn object_to_string() {
     assert_eq!(forward(&mut ctx, "re.toString()"), "\"[object RegExp]\"");
     assert_eq!(forward(&mut ctx, "o.toString()"), "\"[object Object]\"");
 }
+
+#[test]
+fn define_symbol_property() {
+    let mut ctx = Context::new();
+
+    let init = r#"
+        let obj = {};
+        let sym = Symbol("key");
+        Object.defineProperty(obj, sym, { value: "val" });
+    "#;
+    eprintln!("{}", forward(&mut ctx, init));
+
+    assert_eq!(forward(&mut ctx, "obj[sym]"), "\"val\"");
+}

boa/src/property/mod.rs

@@ -293,6 +293,17 @@ pub enum PropertyKey {
     Index(u32),
 }
 
+impl From<&Value> for PropertyKey {
+    #[inline]
+    fn from(value: &Value) -> PropertyKey {
+        match value {
+            Value::String(ref string) => string.clone().into(),
+            Value::Symbol(ref symbol) => symbol.clone().into(),
+            _ => panic!("Cannot be used as property"),
+        }
+    }
+}
+
 impl From<RcString> for PropertyKey {
     #[inline]
     fn from(string: RcString) -> PropertyKey {