Skip to content

Commit

Permalink
docs: adding missing info from the changelog and improve vars (#43)
Browse files Browse the repository at this point in the history
  • Loading branch information
hugoalmeida264 authored Jun 10, 2024
1 parent 49f1eb8 commit 9926aab
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 6 deletions.
13 changes: 12 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- feat: expand volume block of the task definition as it has more configuration
- feat: Add example for service security group using a security group id for `service_ingress_sg`

## [1.12.2] - 2024-06-10
### Changes
- docs: Improve variables text and change the domain name of the private acm

## [1.12.1] - 2024-06-10
### Changes
- docs: Add sg's to the external-lb example

## [1.12.0] - 2024-05-28
### Changes
- feat: Add progate tags to the ecs service
Expand Down Expand Up @@ -173,8 +181,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- feat: feature update.
- feat: initial code commit

[Unreleased]: https://github.com/boldlink/terraform-aws-ecs-service/compare/1.11.0...HEAD
[Unreleased]: https://github.com/boldlink/terraform-aws-ecs-service/compare/1.12.2...HEAD

[1.12.2]: https://github.com/boldlink/terraform-aws-ecs-service/releases/tag/1.12.2
[1.12.1]: https://github.com/boldlink/terraform-aws-ecs-service/releases/tag/1.12.1
[1.12.0]: https://github.com/boldlink/terraform-aws-ecs-service/releases/tag/1.12.0
[1.11.0]: https://github.com/boldlink/terraform-aws-ecs-service/releases/tag/1.11.0
[1.10.0]: https://github.com/boldlink/terraform-aws-ecs-service/releases/tag/1.10.0
[1.9.0]: https://github.com/boldlink/terraform-aws-ecs-service/releases/tag/1.9.0
Expand Down
10 changes: 5 additions & 5 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,12 @@ variable "volume_name" {

variable "load_balancer" {
description = <<-EOT
(Optional) Configuration block for load balancers, accepts the following arguments:
(Optional) Configuration block when you use a external load balancer, ex shared LB, accepts the following arguments:
load_balancer = [{
container_name = string # Name of the container to associate with the load balancer
container_port = number # Port number the container listens on
target_group_arn = string # ARN of the target group to associate with the load balancer when using an external Alb/NLB
container_name = string
container_port = number
target_group_arn = string
}]
EOT
Expand Down Expand Up @@ -244,7 +244,7 @@ variable "default_type" {
variable "self_signed_cert_common_name" {
type = string
description = "Distinguished name"
default = "devboldlink.wpengine.com"
default = "devboldlink.boldlink.io"
}

variable "self_signed_cert_organization" {
Expand Down

0 comments on commit 9926aab

Please sign in to comment.