Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding missing info from the changelog and improve vars #43

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

hugoalmeida264
Copy link
Member

Description

adding missing info from the changelog and improve vars

Checklists:

PR Owners Checklist:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked there aren't open Pull Requests of upstream or parallel code that will cause conflicts?
  • Have you updated the CHANGELOG.md?
  • Have you updated the README.md(s)?
  • OWNER: Does your submission pass?
    • Pre-commit (attach logs/print screen to this PR)
    • Checkov/terrascan (attach logs/print screen to this PR)
    • Terraform resources examples build/destroy successfully with Terraform 0.14.11 minimum?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • First PR? Have you deleted ## How to use this template... from the root .README.md?

PR Reviewers Checklists?

  • Are all your comments/changes resolved?
  • Are you happy with the OWNER checklists and additional information provided?
  • Does your review tests pass?
    • Terraform resources examples build/destroy successfully with Terraform 0.14.11 minimum?

@hugoalmeida264 hugoalmeida264 requested review from a team as code owners June 10, 2024 15:10
@hugoalmeida264 hugoalmeida264 merged commit 9926aab into main Jun 10, 2024
2 of 3 checks passed
@hugoalmeida264 hugoalmeida264 deleted the docs/varsChangelog branch June 10, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant