Cache setLink in Canonical
#2887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobdenotter
commented
Oct 26, 2021
I-Valchev
requested changes
Oct 28, 2021
| $cacheKey = 'bolt.generateLink_' . md5($route . implode('-', $params) . (string) $canonical); | ||
|
|
||
| $link = $this->cache->get($cacheKey, function (ItemInterface $item) use ($route, $params, $canonical) { | ||
| $item->tag('routes'); |
There was a problem hiding this comment.
@bobdenotter I see these popping up in a few places now. Should we create an enum-type class like that?
https://github.com/bolt/core/blob/master/src/Enum/UserStatus.php
Especially since it could be that extensions also may need to clear cache after performing some operations?
Leaving it here as a general comment for all relate PRs 🤔
There was a problem hiding this comment.
Yes, good idea! I'll do this in a separate PR, though.
Merged
|
Closed in favor of #2980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out part of #2853
Note: This breaks stuff if you change the
bolt.backend_urlinservices.yaml.We'll need to somehow detect changes in config, and call
$this->cache->invalidateTags(['routes']);