Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve caching #2980

Merged
merged 9 commits into from
Nov 29, 2021
Merged

Improve caching #2980

merged 9 commits into from
Nov 29, 2021

Conversation

bobdenotter
Copy link
Member

@bobdenotter bobdenotter commented Nov 27, 2021 •
edited
Loading

Enhances #2957

Replaces #2887, #2890

@bobdenotter bobdenotter mentioned this pull request Nov 27, 2021
Closed
@bobdenotter bobdenotter marked this pull request as ready for review November 28, 2021 11:49
I-Valchev
I-Valchev approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@I-Valchev I-Valchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! We'd need to add the yaml migrations for the decorating services.

Joossensei
Joossensei approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@Joossensei Joossensei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Lets see if this will help with Cypress tests 😁

@bobdenotter bobdenotter mentioned this pull request Nov 29, 2021
Closed
@bobdenotter
Copy link
Member Author

We'd need to add the yaml migrations for the decorating services.

Added an issue for that! 👍

@bobdenotter bobdenotter merged commit fbd72ad into master Nov 29, 2021
@bobdenotter bobdenotter deleted the improve-caching branch November 29, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joossensei Joossensei Joossensei approved these changes

@I-Valchev I-Valchev I-Valchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bolt 5.1: Minor Feature release
Development

Successfully merging this pull request may close these issues.
3 participants
@bobdenotter @I-Valchev @Joossensei