Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/tensor refactor #115

Merged
merged 59 commits into from
May 24, 2021
Merged

Features/tensor refactor #115

merged 59 commits into from
May 24, 2021

Conversation

bassoy
Copy link
Collaborator

@bassoy bassoy commented May 23, 2021 •
edited
Loading

  1. Renamed and restructured extents types
  2. Removed type traits for extents and strides types
  3. Removed the old strides type. Strides are now the base type of the corresponding extents type (resolving issue Computation of the resulting static shape for the general tensor multiplication is not correct #111 )
  4. Created common non-member functions for extents
  5. Created special non-member for constexpr evaluation of static extents traits
  6. Created new Matlab like functions such as ones and zeros
  7. Removed old CI files for travis and appveyor
  8. Removed unnecessary CI badges in README

Cem Bassoy and others added 30 commits April 25, 2021 13:32
minimal refactoring of extents type.
fbb870b
adjusting extents with dynamic and static rank. minimizing the number…
d91b96d 
… of functions using the standard library.
[tensor] type traits functions for extents and strides deleted and in…
5c7f82d 
…terfaces simplified.
clang warnings resolved.
e1819cc
clang tidy updated. warnings as errors reduced to clang static analyzer.
4ab7566
modification for c++20 usage with clang.
2c2f4ca
updating github action yml files to support only cxxstd 20
6dc44fb
minor modifications for tensor and shape with static order.
9ef07ba
configuration files modified for github workflow
b74f832
tests with static shape and shape with static rank modifed as msvc 19…
25ef38c 
…28 does not compile.
cleaning up code for clang-tidy.
4d4f105
[FIX] fixes to all tensor tests to pass clang-tidy checks.
8194c93
[FIX] fixes to all tensor tests to pass clang-tidy checks.
03a49a5
updating github action yml files for a more convenient usage.
8905cd6
freeing functions for the extents type.
23b56bc
minor changes on extents with dynamic and static order.
cc5869d
@amitsingh19975
Decouping the constructor from the type extent
82fdf9b
@amitsingh19975
refactor code and add std::get to get the element from the extents
af7da45
@amitsingh19975
simplify static strides using C++20
dcea355
@amitsingh19975
fix clang-tidy warnings
d526963
@amitsingh19975
refactor the calculation of strides
c6b0dae
@amitsingh19975
make reshape a free function and create new headers in order to decou…
701f1b8 
…ple static, dynamic, and fixed rank tensor
@amitsingh19975
fix reshape in the examples
f1c409f
@amitsingh19975
add tuple header to get std::tuple_size
533db85
@amitsingh19975
fix msvc bug
19e8c19
@amitsingh19975
enable apple workflow
dd0da73
@amitsingh19975
refactor for_each_* implementation
7e0a1de
@amitsingh19975
delete move constructs from the tensor expression
3590dfb
@amitsingh19975
update apple.yml to support MacOS 11.0
a3294cd
@amitsingh19975
reverting back to MacOS to 10.15 because 11.0 is a closed pool right now
4f74397
@bassoy bassoy self-assigned this May 23, 2021
amitsingh19975
amitsingh19975 reviewed May 23, 2021
View reviewed changes
Copy link
Collaborator

@amitsingh19975 amitsingh19975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One step closer to improve the uBLAS.

github-actions[bot]
github-actions bot reviewed May 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reports by clang tidy

test/tensor/test_static_tensor_matrix_vector.cpp Outdated Show resolved Hide resolved
test/tensor/test_tensor_matrix_vector.cpp Outdated Show resolved Hide resolved
include/boost/numeric/ublas/tensor/extents/extents_dynamic_size.hpp Show resolved Hide resolved
include/boost/numeric/ublas/tensor/extents/extents_static_size.hpp Show resolved Hide resolved
include/boost/numeric/ublas/tensor/tensor/tensor_dynamic.hpp Show resolved Hide resolved
include/boost/numeric/ublas/tensor/tensor/tensor_static.hpp Show resolved Hide resolved
include/boost/numeric/ublas/tensor/tensor/tensor_static_rank.hpp Show resolved Hide resolved
@github-actions
Copy link

This Pull request Passed all of clang-tidy tests. 👍

@bassoy
Copy link
Collaborator Author

bassoy commented May 23, 2021

improve

@bassoy bassoy closed this May 23, 2021
@bassoy bassoy reopened this May 23, 2021
github-actions[bot]
github-actions bot reviewed May 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reports by clang tidy

test/tensor/test_static_tensor_matrix_vector.cpp Show resolved Hide resolved
test/tensor/test_tensor_matrix_vector.cpp Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed May 23, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reports by clang tidy

examples/tensor/multiply_tensors_einstein_notation.cpp Show resolved Hide resolved
@bassoy bassoy merged commit db29cdf into develop May 24, 2021
@bassoy bassoy deleted the features/tensor_refactor branch May 24, 2021 18:52
bassoy added a commit that referenced this pull request Sep 9, 2021
@bassoy
refactor(core): simplify and eliminate auxiliary tensor types (#115)
231ba5f 
Auxiliary functions for extents and strides were using different
functions. Additionally, many tags were used to distinguish between
different tensor types. This patch simplifies interfaces of different
core functions and unifies functions that can process different types of
extent and stride types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitsingh19975 amitsingh19975 amitsingh19975 left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@stefanseefeld stefanseefeld Awaiting requested review from stefanseefeld

@yimyom yimyom Awaiting requested review from yimyom

Assignees

@bassoy bassoy

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bassoy @amitsingh19975