Features/tensor refactor

.clang-tidy

@@ -1,11 +1,15 @@
 ---
-Checks:  '-*,modernize-*,cppcoreguidelines-*,openmp-*,bugprone-*,performance-*,portability-*,readability-*,-modernize-use-trailing-return-type,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-readability-uppercase-literal-suffix,-readability-braces-around-statements'
-WarningsAsErrors: '-*,modernize-*,cppcoreguidelines-*,openmp-*,bugprone-*,performance-*,portability-*,readability-*,-modernize-use-trailing-return-type,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-readability-uppercase-literal-suffix,-readability-braces-around-statements'
+Checks: '-*,clang-*,bugprone-*,cppcoreguidelines-*,google-*,hicpp-*,modernize-*,performance-*,readability-*,portability-*,
+-modernize-use-trailing-return-type, -readability-uppercase-literal-suffix, -readability-braces-around-statements, -hicpp-uppercase-literal-suffix, -hicpp-braces-around-statements, -hicpp-no-array-decay, -cppcoreguidelines-pro-bounds-constant-array-index, -cppcoreguidelines-pro-bounds-pointer-arithmetic, -cppcoreguidelines-pro-bounds-array-to-pointer-decay, -readability-avoid-const-params-in-decls, -google-readability-braces-around-statements,-google-explicit-constructor,-hicpp-vararg,-cppcoreguidelines-pro-type-vararg, -cppcoreguidelines-avoid-non-const-global-variables, -google-readability-todo, -cppcoreguidelines-pro-type-member-init, -hicpp-member-init'
 HeaderFilterRegex: 'boost\/numeric\/ublas\/tensor\/.*'
 AnalyzeTemporaryDtors: false
 FormatStyle: file
 User: ublas-developers
 CheckOptions:
  - key: modernize-use-nullptr.NullMacros
  value: 'NULL'
+ - key: readability-magic-numbers.IgnoredIntegerValues
+ value: '1;2;3;4;5;6;7;8;9;'
+ - key: cppcoreguidelines-avoid-magic-numbers.IgnoredIntegerValues
+ value: '1;2;3;4;5;6;7;8;9;'
 ...

.github/workflows/apple_clang.yml → .github/workflows/apple.yml

@@ -1,8 +1,9 @@
 # Copyright (c) 2020 Mohammad Ashar Khan
+# Copyright (c) 2021 Cem Bassoy
 # Distributed under Boost Software License, Version 1.0
 # (See accompanying file LICENSE_1_0.txt or copy at http://boost.org/LICENSE_1_0.txt)
 
-name: Apple Clang
+name: "Apple MacOS"
 
 on: 
  push:
@@ -15,24 +16,26 @@ on:
  - 'doc/**'
 jobs:
  build:
- name: "Darwin 11.0 -std=c++${{matrix.cxxstd}}"
- runs-on: macos-latest
+ name: "MacOS 10.15 clang -std=c++${{matrix.cxxstd}}"
+ runs-on: macos-10.15
  strategy:
- fail-fast: false
+ fail-fast: true
  matrix:
- cxxstd: [11, 17, 2a]
+ cxxstd: [2a]
 
  steps:
  - uses: actions/checkout@v2
 
- - name: Prepare BOOST_ROOT
+ - name: Git Clone Boost.uBlas
  run: |
  cd ${GITHUB_WORKSPACE}
  cd ..
 
  git clone -b master --depth 1 https://github.com/boostorg/boost.git boost-root
  cd boost-root
-
+ echo "BOOST_ROOT=${PWD}" >> ${GITHUB_ENV}
+ echo $BOOST_ROOT
+
  git submodule update --init --depth=1 --jobs 8 tools/build
  git submodule update --init --depth=1 --jobs 8 libs/config
  git submodule update --init --depth=1 --jobs 8 tools/boostdep
@@ -41,33 +44,29 @@ jobs:
  cp -rp ${GITHUB_WORKSPACE}/. libs/numeric/ublas
  python tools/boostdep/depinst/depinst.py -g " --depth=1" -I benchmarks numeric/ublas
 
- ./bootstrap.sh
- ./b2 -j 8 headers
-
- #echo ::set-env name=BOOST_ROOT::${PWD}
- echo "BOOST_ROOT=${PWD}" >> ${GITHUB_ENV}
-
- - name: Prepare Build
+ - name: Bootstrap and Compile Boost.uBlas
  run: |
- echo $BOOST_ROOT
  cd $BOOST_ROOT
-
- echo "using clang : : clang++ ;" >> ~/user-config.jam;
-
+ ./bootstrap.sh
+ ./b2 -j8 headers
+ echo "using clang : : $(brew --prefix llvm)/bin/clang++ ;" >> ~/user-config.jam;
+
+
  - name: Test Benchmarks
  run: |
  cd $BOOST_ROOT
  cd libs/numeric/ublas
- $BOOST_ROOT/b2 -j 4 benchmarks toolset=clang cxxstd=${{matrix.cxxstd}}
+ $BOOST_ROOT/b2 -j8 benchmarks cxxstd=${{matrix.cxxstd}}
 
  - name: Test Tensor Examples
  run: |
  cd $BOOST_ROOT
  cd libs/numeric/ublas
- $BOOST_ROOT/b2 -j 4 examples/tensor toolset=clang cxxstd=${{matrix.cxxstd}}
+ $BOOST_ROOT/b2 -j8 examples/tensor cxxstd=${{matrix.cxxstd}}
 
  - name: Test Tensor
  run: |
  cd $BOOST_ROOT
  cd libs/numeric/ublas
- $BOOST_ROOT/b2 -j 4 test/tensor toolset=clang cxxstd=${{matrix.cxxstd}}
+ $BOOST_ROOT/b2 -j8 test/tensor cxxstd=${{matrix.cxxstd}}
+

.github/workflows/clangtidy_review.yml → .github/workflows/clangtidy.yml

@@ -1,26 +1,30 @@
 # Copyright (c) 2020 Mohammad Ashar Khan
+# Copyright (c) 2021 Cem Bassoy
 # Distributed under Boost Software License, Version 1.0
 # (See accompanying file LICENSE_1_0.txt or copy at http://boost.org/LICENSE_1_0.txt)
 
-name: Clang tidy Review
-
-on: [pull_request]
-
+name: "Static Analysis"
+
+on: 
+ push:
+ paths-ignore: 
+ - '**.md'
+ - 'doc/**'
+ pull_request:
+ paths-ignore: 
+ - '**.md'
+ - 'doc/**'
 jobs:
  check:
- name: Clang tidy Review 
+ name: Linux Clang-Tidy
  runs-on: ubuntu-20.04
- if: github.event.pull_request.head.repo.full_name == github.repository
  steps:
- - uses: actions/checkout@v2 
- - name: "Install dependencies"
- run: |
- wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key 2>/dev/null | sudo apt-key add -
- sudo add-apt-repository 'deb http://apt.llvm.org/focal llvm-toolchain-focal-10 main' -y
- sudo apt-get update -q
- sudo apt-get install -y clang-10 clang-tidy-10
+ - uses: actions/checkout@v2
+
+ - name: Install Clang 11
+ run: sudo apt-get update && sudo apt-get install -y clang-11 clang-tidy-11
 
- - name: "Install Boost from Source" 
+ - name: "Install Boost from Source"
  run: |
  cd ..
  git clone --depth 1 https://github.com/boostorg/boost.git --recursive --shallow-submodules
@@ -29,19 +33,20 @@ jobs:
  ./b2 headers
  sudo cp -r -L boost /usr/include
  rm -rf boost
+
+ - name: "Run Clang-Tidy"
+ run: clang-tidy-11 examples/tensor/*.cpp test/tensor/*.cpp -- -Iinclude -std=c++20 > reports.txt
 
+ - name: "Print Clang-Tidy Report"
+ run: cat reports.txt
+
  - uses: actions/setup-python@v2
-
- - name: "Run clang-tidy check"
- run: |
- clang-tidy-10 examples/tensor/*.cpp -- -Iinclude -std=c++17 > reports.txt
-
+
  - name: "Post review comments"
- if: always()
+ if: github.event.pull_request.head.repo.full_name == github.repository
  run: |
  pip3 install 'unidiff~=0.6.0' --force-reinstall
  pip3 install 'PyGithub~=1.51' --force-reinstall
  pip3 install 'requests~=2.23' --force-reinstall
-
- python ./.ci/post_review.py --repository ${{ github.repository }} --token ${{ github.token}} --pr ${{ github.event.pull_request.number }} --path reports.txt
-
+ python ./.ci/post_review.py --repository ${{ github.repository }} --token ${{ github.token}} --pr ${{ github.event.pull_request.number }} --path reports.txt 
+

.github/workflows/code_format.yml

@@ -2,7 +2,7 @@
 # Distributed under Boost Software License, Version 1.0
 # (See accompanying file LICENSE_1_0.txt or copy at http://boost.org/LICENSE_1_0.txt)
 
-name: "Code Format"
+name: "Clang Code Format"
 
 on: 
  push:
@@ -15,7 +15,7 @@ on:
  - 'doc/**'
 jobs:
  format:
- name: "Code Formatting Check"
+ name: "Clang Code Formatting Check"
  runs-on: ubuntu-20.04
  steps:
  - uses: actions/checkout@v2
@@ -24,8 +24,8 @@ jobs:
  run: |
  sudo apt-get install -y clang-format-10
 
- - name: "Format Codes"
- run: clang-format-10 -i examples/tensor/*.cpp test/tensor/*.cpp include/boost/numeric/ublas/tensor/*.hpp include/boost/numeric/ublas/tensor/*/*.hpp
+# - name: "Format Codes"
+# run: clang-format-10 -i examples/tensor/*.cpp test/tensor/*.cpp include/boost/numeric/ublas/tensor/*.hpp include/boost/numeric/ublas/tensor/*/*.hpp
 
- - name: Check diff
- run: git diff --exit-code HEAD
+# - name: Check diff
+# run: git diff --exit-code HEAD