Wait longer for vm to boot #270
Conversation
because we're generating certs. Signed-off-by: Ben Firshman <ben@firshman.co.uk>
Signed-off-by: Ben Firshman <ben@firshman.co.uk>
|
Makes me a little sick to my stomach that we're playing a shell game here with timeouts, but fair enough. 😄 LGTM |
| @@ -128,7 +128,7 @@ func cmdUp() error { | |||
| } | |||
| // Copying the certs here - someone might have have written a Windows API client. | |||
| certPath, err := RequestCertsUsingSSH(m) | |||
| if err != nil && B2D.Verbose { | |||
| if err != nil { | |||
| // These errors are not fatal | |||
| fmt.Fprintf(os.Stderr, "Error copying Certificates: %s\n", err) | |||
There was a problem hiding this comment.
How about adding:
"Warning: error copying...
There was a problem hiding this comment.
I'll go ahead and add these text changes in master now that this is merged. Thanks @gmlewis ❤️
|
Still getting errors, even with this change.
|
|
#277 seems to help with this, but I am still sometimes seeing failures on boot, particularly inside a VM which is slower anyway. My machine is reasonably fast – an i7 Macbook Air – so I'm assuming there will be a lot more slower machines in the wild. |
|
So I'm going to merge this for 1.3.0, since better safe than sorry, and we can iterate on a better solution afterwards. Hopefully everyone thinks that's fair. 😄 |
|
As you can see, copy edits in 24240ad ❤️ |
|
I'm sorry to say that this PR did not stop the timeout failure. I'm going to try something... |
Because we're generating certs.