Deal with cert generation taking too long, re...

[SvenDowideit]

...place with extra retries and add cmdline flag in case someone has a much slower system

replaces #270, which didn't do enough for the VM I have.

• this increases the number of retries (ie, has no effect on faster booting systems),
• adds a --retries=45 and --waittime=300 flags to allow it to be set in someone's config file
• changes one of the . 's into o, so you can tell the difference between wait for sshd and then wait for docker daemon

@gmlewis @bfirsh, @tianon please consider :)

[gmlewis]

LGTM

[bfirsh]

Still seeing timeouts:

Waiting for VM and Docker daemon to start...
.......................................ooooooooooooooooooooooooooooooooooooooo
Started.
  Trying to get Docker socket one more time
Error requesting socket: exit status 1
Auto detection of the VM's Docker socket failed.
Please run `boot2docker -v up` to diagnose.

bash-3.2$ $(/usr/local/bin/boot2docker shellinit)
error in run: Error requesting socket: exit status 1

bash-3.2$ docker version
Client version: 1.3.0
Client API version: 1.15
Go version (client): go1.3.3
Git commit (client): c3b9b46
OS/Arch (client): darwin/amd64
2014/10/15 02:59:23 Get http:///var/run/docker.sock/v1.15/version: dial unix /var/run/docker.sock: no such file or directory
bash-3.2$ boot2docker up
Waiting for VM and Docker daemon to start...
.ooooooooooooooooooo
Started.
Writing /Users/ben/.boot2docker/certs/boot2docker-vm/ca.pem
Writing /Users/ben/.boot2docker/certs/boot2docker-vm/cert.pem
Writing /Users/ben/.boot2docker/certs/boot2docker-vm/key.pem

To connect the Docker client to the Docker daemon, please set:
    export DOCKER_HOST=tcp://192.168.59.103:2376
    export DOCKER_CERT_PATH=/Users/ben/.boot2docker/certs/boot2docker-vm
    export DOCKER_TLS_VERIFY=1

bash-3.2$ 

What's the harm in increasing the default number of retries? That an actual error will take a couple of minutes to appear?

[SvenDowideit]

There should be little harm in picking any number you like - how high do you need to go before it works?

(I'm guessing from the output, somewhere near 60 :( )

[bfirsh]

75 seems to work reliably.

[bfirsh]

Apart from that, LGTM.

[tianon]

LGTM

[tianon]

What would be the harm in increasing the number of timeouts to 75 for everyone? It's obscene, yes, but if it works more reliably?

[bfirsh]

@tianon there is no harm. I can put together another PR to amend if you'd like.

[tianon]

You're heading to bed - I'll just merge this and make a new PR. Focus on those other two PRs in the little time you have left. 😄