Support custom image compression #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@tofay is this PR ready for review? |
tofay
force-pushed
the
generic
branch
2 times, most recently
from
6ed7718 to
761f436
Compare
tofay
force-pushed
the
generic
branch
2 times, most recently
from
1b560c3 to
e027c78
Compare
Signed-off-by: Tom Fay <tom@teamfay.co.uk>
cgwalters
approved these changes
Jun 30, 2025
cgwalters
approved these changes
Jun 30, 2025
Signed-off-by: Tom Fay <tom@teamfay.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #24 (comment)
Users can bring their own compression by implementing the
WriteCompletetrait, and providing a closure that creates their Writer from a blob writer.An example use case I've been experimenting with for faster compression is to use multithreaded gzip compression via https://github.com/sstadick/gzp (or a fork which resolves sstadick/gzp#56 ) - I added an example of how I've done that here, alongside a trivial example that does no compression. I'll remove the gzp example to avoid using my github branch but included it initially to demonstrate the use case.