-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new method names in gtsam SfmTrack and SfmData #451
Conversation
Need to update the GTSAM wheel in the CI, left a TODO in setup.py |
thanks for the PR, @akshay-krishnan. A few more names for us to update, according to the CI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might also need to update the wheel links in the README.
.github/scripts/setup.sh
Outdated
unzip gtsam-4.2a5-cp38-cp38-manylinux2014_x86_64.whl.zip | ||
pip install gtsam-4.2a5-cp38-cp38-manylinux2014_x86_64.whl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can export the name to make it easier from next time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
udpated, hopefully the change is what you meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, very nice. Thanks Akshay
This only changes some method names, for ex: number_measurements() - > numberMeasurements(), add_measurement() -> addMeasurement(), due to the change on gtsam.
GTSAM PR: borglab/gtsam#1082