Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/adapt tests for warning #70

Merged
merged 23 commits into from
Dec 9, 2024
Merged

Feature/adapt tests for warning #70

merged 23 commits into from
Dec 9, 2024

Conversation

ant-u
Copy link
Collaborator

@ant-u ant-u commented Nov 11, 2024

Goals:

  • check for scheme version and validity
  • consider version in following checks, e.g. sourcefile attribute

ant-u added 14 commits April 2, 2024 10:56
@ant-u
changed each test to also check for warnings and specified which warn…
a3cac85 
…ing must be displayed

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
implemented change requests
183d2b7 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge branch 'main' into feature/adapt_tests_for_warning
473b6ab 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
linter issues
55e2230 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added location of check
d21b4de 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added check class
6ca9be7 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added test for xml conformity
2da0559 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added check for validating xml with scheme, output not yet processed …
01d8ef7 
…though

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
created whole check out of validation function. introduced success an…
7bf022e 
…d failure messages

Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
Merge branch 'main' into feature/adapt_tests_for_warning
0a47e98 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
corrected double code
03279cb 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
moved check to extra file
9dc4761 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
fixed imports and whitespaces
abf0c4d 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed if structure of _check method
8687856 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
705 661 94% 90% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 55962ce by action🐍

ant-u added 8 commits November 25, 2024 11:41
@ant-u
changed tests to all fullfill scheme version
3d57102 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
changed test data with source-file attribute to version 4
dbef936 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
added case for package.xml version 4
cd379e5 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
removed todo
9330eb2 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
adapted wrong test
3ece023 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
moved version checking and xml tree conversion to package.py
bc4fabf 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
refactor of schema check
9716639 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u
fixed bug
bab6691 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ant-u ant-u marked this pull request as ready for review December 5, 2024 08:11
@ant-u ant-u requested a review from ct2034 December 5, 2024 08:11
@ant-u ant-u self-assigned this Dec 5, 2024
ct2034
ct2034 requested changes Dec 9, 2024
View reviewed changes
schemas/package_common.xsd Show resolved Hide resolved
src/ros_license_toolkit/checks.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/license_checks/license_in_code_check.py Outdated Show resolved Hide resolved
src/ros_license_toolkit/license_checks/schema_check.py Show resolved Hide resolved
src/ros_license_toolkit/license_checks/schema_check.py Show resolved Hide resolved
src/ros_license_toolkit/license_checks/schema_check.py Show resolved Hide resolved
src/ros_license_toolkit/main.py Outdated Show resolved Hide resolved
test/systemtest/test_separate_pkgs.py Show resolved Hide resolved
@ant-u
implemented suggestions
55962ce 
Signed-off-by: Anton Utz <uta5fe@bosch.com>
@ct2034 ct2034 merged commit 38e165a into main Dec 9, 2024
12 checks passed
@ct2034 ct2034 deleted the feature/adapt_tests_for_warning branch December 9, 2024 20:32
@ct2034 ct2034 mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ct2034 ct2034 ct2034 approved these changes

Assignees

@ant-u ant-u

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ant-u @ct2034