Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation warnings found during running tests #1674

Closed
wants to merge 3 commits into from

Conversation

mikedlr
Copy link

@mikedlr mikedlr commented Jan 27, 2019

Running some test cases I got a bunch of deprecation warnings.

This is a very simple patch to eliminate those. Mostly trivial docstring changes but one set of collections abstract base class changes which will cause compatibility problems with python 3.8.

@mikedlr
Copy link
Author

mikedlr commented Jan 27, 2019

I think that #1675 fixes the reason why my tests were calling in to the vendored code.

@codecov-io
Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #1674 into develop will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1674      +/-   ##
===========================================
+ Coverage    92.07%   92.42%   +0.35%     
===========================================
  Files           53       53              
  Lines         9824     9871      +47     
===========================================
+ Hits          9045     9123      +78     
+ Misses         779      748      -31
Impacted Files Coverage Δ
botocore/eventstream.py 100% <0%> (ø) ⬆️
botocore/parsers.py 99.79% <0%> (+0.01%) ⬆️
botocore/model.py 97.81% <0%> (+0.04%) ⬆️
botocore/utils.py 97.62% <0%> (+0.16%) ⬆️
botocore/hooks.py 96.38% <0%> (+0.4%) ⬆️
botocore/handlers.py 97.11% <0%> (+0.42%) ⬆️
botocore/compat.py 93.92% <0%> (+4.97%) ⬆️
botocore/awsrequest.py 98.36% <0%> (+5.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ada95...29df487. Read the comment docs.

@Jamim
Copy link

Jamim commented Jun 15, 2019

Hello @jamesls,

Could you please take a look at this PR?

Thanks!

@nateprewitt
Copy link
Contributor

This file ended up getting removed when we unvendored urllib3. It should now be compliant when installing a current version of urllib3. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants