Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unvendor urllib in exceptions class #1675

Closed

Conversation

mikedlr
Copy link

@mikedlr mikedlr commented Jan 27, 2019

According to

urllib has been unvendored and should not be used any more. In the exceptions class however there's still a reference to it I found with

grep -r import .| grep urllib3  | grep botocore.vendored

this patch removes the urllib vendoring in the exceptions class. Maybe rules like the grep above should also be added to the CI to ensure that all deprecated vendored classes stay removed?

@nateprewitt
Copy link
Contributor

Thanks for the PR, @mikedlr. While we did remove the majority of the vendored code, we still provide exceptions from this folder. In order to maintain consistency in existing code, we're going to leave this reference for now. In a future version, we may revisit this change if our stance on the current vendoring changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants