Remove duplicate retry handler registration #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LimitExceededException doesn't apply to just DescribeStream and the client-based retry handler doesn't support per-operation retries.
The retry handlers that hook up to service-data-loaded were added before botocore clients were added. This results in the client level retry handlers being a no-op if they were already loaded (they use the same unique_id). This means you can have subtly different behavior depending on if you (or something else) calls `session.get_service_data()`.
Codecov Report
@@ Coverage Diff @@
## develop #1719 +/- ##
===========================================
- Coverage 92.45% 92.41% -0.05%
===========================================
Files 53 53
Lines 9872 9843 -29
===========================================
- Hits 9127 9096 -31
- Misses 745 747 +2
Continue to review full report at Codecov.
|
JordonPhillips
approved these changes
Apr 25, 2019
There was a problem hiding this comment.
We could just introduce per-operation retry functionality to the client handler, but like you mention in the linked issue I don't think we need to worry too much about people having their own retry config. It was always an internal implementation detail anyway.
jamesls
added a commit
that referenced
this pull request
May 17, 2019
PR #1719 * remove-dupe-retry: Remove duplicate retry handler registration Change kinesis per-op to be per-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retry handlers that hook up to service-data-loaded
were added before botocore clients were added. This results
in the client level retry handlers being a no-op if they were
already loaded (they use the same unique_id).
This means you can have subtly different behavior
depending on if you (or something else) calls
session.get_service_data().I also changed kinesis per-op to be per-service
The LimitExceededException doesn't apply to just
DescribeStream and the client-based retry handler
doesn't support per-operation retries.
This also ensures we continue to retry this
exception in kinesis for DescribeStream without
requiring per-operation retry functionality.
Fixes #1698