Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate retry handler registration #1719

Merged
merged 2 commits into from
May 17, 2019
Merged

Remove duplicate retry handler registration #1719

merged 2 commits into from
May 17, 2019

Commits on Apr 17, 2019

  1. Change kinesis per-op to be per-service 

    The LimitExceededException doesn't apply to just
DescribeStream and the client-based retry handler
doesn't support per-operation retries.
    @jamesls
    jamesls committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    17007f9 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate retry handler registration 

    The retry handlers that hook up to service-data-loaded
were added before botocore clients were added.  This results
in the client level retry handlers being a no-op if they were
already loaded (they use the same unique_id).

This means you can have subtly different behavior
depending on if you (or something else) calls
`session.get_service_data()`.
    @jamesls
    jamesls committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    ffaf4e6 View commit details
    Browse the repository at this point in the history