Update host-ctr Go dependencies #337
Conversation
piyush-jena
force-pushed
the
go_updates
branch
from
81476a8 to
8b5b098
Compare
| go 1.22.0 | ||
| go 1.23.0 | ||
|
|
||
| toolchain go1.22.2 | ||
| toolchain go1.23.3 |
There was a problem hiding this comment.
Sorry, but I'm a Golang toolchain novice. Do we actually want to bump the version of the go compiler used here?
Are these values informed by requirements of our dependencies, or do we get to control them?
There was a problem hiding this comment.
I am a novice too. But I can explain the reason why I did that.
I installed golang version 1.22.x in my system. Then ran,
go get -u github.com/containerd/containerd@v1.7.22 ./...
go mod tidy
go mod vendor
With golang 1.22 none of the packages were updates but I did get a lot of warnings saying 1.23.0+ version is required. Upgrading golang to 1.23 and running the above commands updated the versions of the required packages. I was able to force update a required package with golang 1.22 by running go get -u xxxxxx but since the package in question is an indirect package I opted for the other method (also golang 1.23 is available in sdk which made me more confident).
To make sure, I ran all the required tests and everything worked as expected. The logs are attached.
|
The current containerd version that we ship is |
piyush-jena
force-pushed
the
go_updates
branch
3 times, most recently
from
f6c9a29 to
a426cfd
Compare
piyush-jena
force-pushed
the
go_updates
branch
from
a426cfd to
f890651
Compare
Description of changes:
Updated Go dependencies with:
I manually held back
github.com/containerd/errdefssince v0.2.0 changes the interfaces and breaks builds for the vendor code as referenced in #146.Testing done:
Built aws-k8s-1.30 for aarch64 and x86_64 and validated that host containers where pulled with no errors in the logs. Both control and admin container pulled and I was able to SSM and check the journal on both.
For x86_64, aws-k8s-1.30
For aarch64, aws-k8s-1.30
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.