license-scan: prepare to publish to crates.io #211
Conversation
| license = "Apache-2.0 OR MIT" | ||
| authors = ["iliana destroyer of worlds <iweller@amazon.com>"] | ||
| repository = "https://github.com/bottlerocket-os/bottlerocket-sdk" | ||
| edition = "2018" |
There was a problem hiding this comment.
| edition = "2018" | |
| edition = "2021" |
Should we bump our edition and rust dependencies before we publish?
There was a problem hiding this comment.
Yes, a dependency bump is definitely in order.
We don't need to increment the edition as a blocker here though, Rust allows editions to peacefully coexist.
cbgbt
force-pushed
the
license-scan-publish
branch
2 times, most recently
from
5035134 to
c4ed74d
Compare
|
^ bump dependencies per @jpculp. For whatever reason my new GitHub action won't run for this PR, but I'm hopeful that it's because it will run hereafter. |
| - "license-scan/**" | ||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
I'm not sure we can use ubuntu-latest as a runner; it might need to be shared from the org level.
I noticed that the only core kit workflow to use this runner - golangci-lint.yaml doesn't seem to have triggered for a recent PR - so this might be a new change.
Try changing it to this and see if the workflow runs:
| runs-on: ubuntu-latest | |
| runs-on: | |
| group: bottlerocket | |
| labels: bottlerocket_ubuntu-latest_8-core |
cbgbt
force-pushed
the
license-scan-publish
branch
7 times, most recently
from
55076cd to
eb3fb63
Compare
|
I've tried all manner of reconfiguring this action and peering into the repository configurations and cannot for the life of me get the action to run in this PR. @bcressey another possible culprit in the core-kit PR is that we possibly need double-wildcards here. In any case, I'd appreciate another review. I'll open a test PR after this one is merged to see if it triggers the workflow. |
Sounds good, let's see what happens! |
Description of changes:
My intent is to follow this PR up with integration of release-plz for automated crate releases.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.