Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.travis: enable 7.4snapshot #192

Merged
merged 1 commit into from
Jul 23, 2019
Merged

.travis: enable 7.4snapshot #192

merged 1 commit into from
Jul 23, 2019

Conversation

kornrunner
Copy link
Contributor

@kornrunner kornrunner commented Jul 23, 2019 •
edited
Loading

Test against 7.4snapshot on Travis

Ref: #189

@kornrunner kornrunner mentioned this pull request Jul 23, 2019
Merged
@mikey179
Copy link
Member

Definitely the right thing to do. Is there a specific reason you put 7.3 into the allow_failures section?

@kornrunner
Copy link
Contributor Author

Yeah - I haven't checked if 7.3 is officially supported within vfsStream. Because it has a failure - I didn't want this to be a showstopper if it gets merged in

@mikey179
Copy link
Member

mikey179 commented Jul 23, 2019 •
edited
Loading

Oh, you are right. Also I was stupid - I had #172 open just minutes before my comment. 🙈

@allejo
Copy link
Member

allejo commented Jul 23, 2019

I've merged #172 (which added 7.3 to Travis). Could you please rebase this on top of master?

As for allowed failures, I'd prefer only nightly but 7.4snapshot can remain there for now while 7.4 compat changes are being made.

@kornrunner kornrunner changed the title .travis: enable 7.3 and 7.4snapshot .travis: enable 7.4snapshot Jul 23, 2019
@kornrunner
Copy link
Contributor Author

Of course, here it goes

@allejo allejo merged commit 64bdc7f into bovigo:master Jul 23, 2019
@allejo
Copy link
Member

allejo commented Jul 23, 2019

Thank you @kornrunner!

@kornrunner kornrunner deleted the travis branch January 18, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kornrunner @mikey179 @allejo