Fix for 7.3: streamed directory are now also executable #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
force-pushed
the
issue-php73
branch
from
482ced6 to
6b06ca5
Compare
|
travis fails with 7.3, but related to asset redifinition in bovigo/assert |
allejo
requested changes
Apr 12, 2019
derrabus
reviewed
Apr 18, 2019
allejo
approved these changes
Jul 23, 2019
|
Was there anything else that needed to be done for 7.3 testing? Otherwise, this looks like it can be merged. |
bizurkur
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catched in Fedoa QA
https://apps.fedoraproject.org/koschei/package/php-mikey179-vfsstream?collection=f30
The PHP 7.3 behavior have changed, more explanation on
php/php-src@94b4abdbc4d