Backport 7.4 support to 1.6.x branch #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaapio
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
Looks good to me, I kind of like the hack you did to make the impact of the changes smaller. We can remove this in the future if we want to. And it shows the minimal changes to get this library working for php 7.4 👍
I had just a few notes which are not blocking for me, but things we might consider to change in a follow up PR.
|
I would give this a go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #195, this PR backports PRs #189 and #172 to the
v1.xbranch.The master branch has had work done in the unit tests over a period of time to upgrade it from PHPUnit 4.5 to 8. Since the
v1.xbranch isn't one we're looking to maintain, I see no reason to dedicate time to updating the unit tests. So, this PR includes some terrible hacks needed to get thev1.xbranch successfully tested all the way from 5.3 up until 7.4. This means we can perform all our testing without having to touch our minimum PHP version in a point release and still test all the versions we support.7.4 support is incredibly trivial for this library, but testing all the versions we support is the difficult part, hence this larger PR.
The
composer.lockfile has been removed in this branch so composer can automatically pick between PHPUnit 4.8 for PHP <= 5.5 and PHPUnit 5.7 for PHP >= 5.6.