Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change entry point in package.json #76

Closed
FabienMotte opened this issue Jun 11, 2015 · 3 comments
Closed

Change entry point in package.json #76

FabienMotte opened this issue Jun 11, 2015 · 3 comments

Comments

@FabienMotte
Copy link

The actual main entry point in package.json file is :

"main": "dist/t3.js"

And this version of T3 still depends on jQuery.

Now that there is a native version of the framework (without jQuery dependency), it would be great to have it included as the new entry point in package.json file :

"main": "dist/t3-native.js"

It would allow us to require('t3js') (with Browserify for example) without the need to require also jQuery and pollute the global scope to make it work with T3.

Any thoughts about it ?

Thanks !

@j3tan
Copy link
Contributor

j3tan commented Jun 11, 2015

Good idea, people using browserify probably have access to es5 or babel. Thoughts @nzakas ?

@nzakas
Copy link
Contributor

nzakas commented Jun 12, 2015

This would be a breaking change as there are some things jQuery allows you to do (custom selectors, focusin, etc.) that native does not. Some discussion around that point: #22

So the real question is if this is important enough to do now and go to 2.0.0, or if we can wait?

@nzakas
Copy link
Contributor

nzakas commented Aug 5, 2015

Just an update: for 2.0.0, we are going to switch the default version of T3 to be the native one, both in package.json and the hosted files. This will be a breaking change, so we'll hold off until to get some non-breaking changes in first.

@nzakas nzakas closed this as completed in 4c7a1c4 Aug 13, 2015
nzakas added a commit that referenced this issue Aug 13, 2015
Breaking: Use NativeDOM by default (fixes #76)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants