Breaking: Use NativeDOM by default (fixes #76) #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verified that @nzakas has signed the CLA. Thanks for the pull request! |
| @@ -31,7 +31,6 @@ var NODE = 'node ', // intentional extra space | |||
|
|
|||
| // Utilities - intentional extra space at the end of each string | |||
| ISTANBUL = NODE + NODE_MODULES + 'istanbul/lib/cli.js ', | |||
| MOCHA = NODE_MODULES + 'mocha/bin/_mocha ', | |||
There was a problem hiding this comment.
any reason to remove this? do we risk using the globally installed mocha instead in the api-test?
There was a problem hiding this comment.
It wasn't being used at all, so this was just a bit of cleanup.
|
lgtm! |
nzakas
added a commit
that referenced
this pull request
Aug 13, 2015
Breaking: Use NativeDOM by default (fixes #76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the default JS file to be native instead of jQuery (both in
distand forpackage.json).Also, added tests of the API to verify the change is correct and to avoid situations like the great missing
DOMEventDelegatecaper.