fix: compensation activity paste now results simple activity

Closes #2070
bpmn-io · Aug 16, 2024 · 2f2816a · 2f2816a
1 parent 8511c2a
commit 2f2816a
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 4 deletions.
diff --git a/lib/features/replace/BpmnReplace.js b/lib/features/replace/BpmnReplace.js
@@ -211,7 +211,7 @@ export default function BpmnReplace(
       }
 
       if (propertyName === 'isForCompensation') {
-        return !isEventSubProcess(newBusinessObject);
+        return false;
       }
 
       return true;

diff --git a/lib/features/rules/BpmnRules.js b/lib/features/rules/BpmnRules.js
@@ -27,7 +27,8 @@ import {
   isInterrupting,
   hasErrorEventDefinition,
   hasEscalationEventDefinition,
-  hasCompensateEventDefinition
+  hasCompensateEventDefinition,
+  isCompensationActivityElement
 } from '../../util/DiUtil';
 
 import RuleProvider from 'diagram-js/lib/features/rules/RuleProvider';
@@ -888,6 +889,15 @@ function canReplace(elements, target, position) {
           });
         }
       }
+
+      if (is(element,'bpmn:Task') && canDrop(element, target)) {
+        if (isCompensationActivityElement(element)) {
+          canExecute.replacements.push({
+            oldElementId: element.id,
+            newElementType: 'bpmn:Task'
+          });
+        }
+      }
     }
 
     if (!is(target, 'bpmn:Transaction')) {

diff --git a/lib/util/DiUtil.js b/lib/util/DiUtil.js
@@ -120,3 +120,12 @@ export function hasEscalationEventDefinition(element) {
 export function hasCompensateEventDefinition(element) {
   return hasEventDefinition(element, 'bpmn:CompensateEventDefinition');
 }
+
+/**
+ * @param {Element} element
+ *
+ * @return {boolean}
+ */
+export function isCompensationActivityElement(element) {
+  return getBusinessObject(element).isForCompensation;
+}
diff --git a/test/spec/features/replace/BpmnReplaceSpec.js b/test/spec/features/replace/BpmnReplaceSpec.js
@@ -1438,7 +1438,7 @@ describe('features/replace - bpmn replace', function() {
     }));
 
 
-    it('should keep isForCompensation attr', inject(function(elementRegistry, bpmnReplace) {
+    it('should not keep isForCompensation attr', inject(function(elementRegistry, bpmnReplace) {
 
       // given
       var task = elementRegistry.get('Task_1');
@@ -1450,7 +1450,7 @@ describe('features/replace - bpmn replace', function() {
       var newElement = bpmnReplace.replaceElement(task, newElementData);
 
       // then
-      expect(newElement.businessObject.isForCompensation).to.be.true;
+      expect(newElement.businessObject.isForCompensation).to.be.false;
     }));
 
   });