Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting Compensation Activity Doesn't Remove isForCompensation Marker #2070

Closed
philippfromme opened this issue Jan 5, 2024 · 0 comments · Fixed by #2220
Closed

Pasting Compensation Activity Doesn't Remove isForCompensation Marker #2070

philippfromme opened this issue Jan 5, 2024 · 0 comments · Fixed by #2220
Assignees
@abdul99ahad
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@philippfromme
Copy link
Contributor

Describe the Bug

When copying and pasting a compensation activity the isForCompensation marker isn't being removed on paste. Since that marker is being added and removed automatically the expectation would be that it's removed on paste and only added once the activity is connected to a compensation boundary event.

brave_kEYQFEpB1V

Steps to Reproduce

  1. Create a compensation activity
  2. Copy and paste the compensation activity
  3. isForCompensation marker isn't being removed

Expected Behavior

isForCompensation marker is removed.

Environment

  • Library version: v16.3.0
@philippfromme philippfromme added the bug Something isn't working label Jan 5, 2024
@philippfromme philippfromme mentioned this issue Jan 5, 2024
Merged
@philippfromme philippfromme added the in progress Currently worked on label Jan 5, 2024 — with bpmn-io-tasks
@philippfromme philippfromme added backlog Queued in backlog spring cleaning Could be cleaned up one day and removed in progress Currently worked on labels Jan 5, 2024
@abdul99ahad abdul99ahad self-assigned this Aug 13, 2024
@abdul99ahad abdul99ahad added in progress Currently worked on and removed backlog Queued in backlog labels Aug 13, 2024
abdul99ahad added a commit that referenced this issue Aug 14, 2024
@abdul99ahad
fix: compensation activity paste now results simple activity
cdfd491 
Closes #2070
@abdul99ahad abdul99ahad mentioned this issue Aug 16, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Aug 16, 2024
abdul99ahad added a commit that referenced this issue Aug 16, 2024
@abdul99ahad
fix: compensation activity paste now results simple activity
2f2816a 
Closes #2070
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Aug 16, 2024
abdul99ahad added a commit that referenced this issue Aug 20, 2024
@abdul99ahad
fix: pasting compensation activity without boundary event
db2f7e1 
Closes #2070
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 20, 2024
@nikku nikku added the in progress Currently worked on label Aug 20, 2024 — with bpmn-io-tasks
@nikku nikku removed the needs review Review pending label Aug 20, 2024
abdul99ahad added a commit that referenced this issue Aug 20, 2024
@abdul99ahad
fix: pasting compensation activity without boundary event
e6c8ff5 
Closes #2070
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 20, 2024
abdul99ahad added a commit that referenced this issue Aug 28, 2024
@abdul99ahad
fix: pasting compensation activity without boundary event
31c1908 
Closes #2070
nikku pushed a commit that referenced this issue Aug 28, 2024
@abdul99ahad @nikku
fix: pasting compensation activity without boundary event
c6bbe5c 
Closes #2070
nikku pushed a commit that referenced this issue Aug 28, 2024
@abdul99ahad @nikku
fix: pasting compensation activity without boundary event
70340aa 
Closes #2070
@nikku nikku closed this as completed in 21e05e4 Aug 28, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 28, 2024
nikku pushed a commit that referenced this issue Sep 9, 2024
@abdul99ahad @nikku
fix: pasting compensation activity without boundary event
4359f18 
Closes #2070
@ElRaptorus ElRaptorus mentioned this issue Jan 9, 2025
Merged
ElRaptorus added a commit to 5minds/bpmn-js that referenced this issue Feb 4, 2025
@ElRaptorus
Bump to 18.1.2 (#9)
a1d927b 
# Changes 

Siehe Changelog:
https://github.com/bpmn-io/bpmn-js/blob/develop/CHANGELOG.md

## 18.1.2

* `FIX`: canvas `autoFocus` must explicitly be enabled
([bpmn-io/diagram-js#956](bpmn-io/diagram-js#956))
* `FIX`: properly integrate `zoomscroll` with canvas focus
([bpmn-io/diagram-js#956](bpmn-io/diagram-js#956))
* `FIX`: properly integrate `movecanvas` with canvas focus
([bpmn-io/diagram-js#956](bpmn-io/diagram-js#956))

## 18.1.1

* `FIX`: adjust search to prioritize start of word and exact matches
([bpmn-io/diagram-js#953](bpmn-io/diagram-js#953))
* `FIX`: ignore whitespace when searching
([bpmn-io/diagram-js#954](bpmn-io/diagram-js#954))

## 18.1.0

* `FIX`: clear selection when opening search pad
([bpmn-io/diagram-js#947](bpmn-io/diagram-js#947))
* `FIX`: correct dangling selection after search pad interaction
([bpmn-io/diagram-js#947](bpmn-io/diagram-js#947))
* `DEPS`: update to `diagram-js@15.2.2`

## 18.0.0

* `FEAT`: remove `outline` from `Viewer` modules
([bpmn-io#2135](bpmn-io#2135))
* `FEAT`: make `Canvas` a focusable element
([bpmn-io/diagram-js#662](bpmn-io/diagram-js#662))
* `FEAT`: implicit keyboard binding
([bpmn-io/diagram-js#662](bpmn-io/diagram-js#662))
* `FEAT`: integrate with global `search`
([bpmn-io#2235](bpmn-io#2235))
* `FEAT`: integrate `popup-menu` with `search`
([bpmn-io/diagram-js#932](bpmn-io/diagram-js#932))
* `FEAT`: recognize modern `search` tokens in `search-pad`
([bpmn-io/diagram-js#932](bpmn-io/diagram-js#932))
* `FIX`: correctly handle duplicate entries and whitespace in `search`
([bpmn-io/diagram-js#932](bpmn-io/diagram-js#932))
* `FIX`: find `search` terms across all keys
([bpmn-io/diagram-js#932](bpmn-io/diagram-js#932))
* `FIX`: `search` always returns tokens for matched items
([bpmn-io/diagram-js#932](bpmn-io/diagram-js#932))
* `FIX`: prevent crash during label adjustment
([bpmn-io#2239](bpmn-io#2239))
* `FIX`: keep existing loop characteristics when toggling through the
replace menu ([bpmn-io#2251](bpmn-io#2251))
* `FIX`: prevent covering multi selection with black box in `Viewer`
([bpmn-io#2135](bpmn-io#2135))
* `FIX`: generate types for main entry
([`986e2bb`](bpmn-io@986e2bb))
* `FIX`: correct handling of group name with whitespace only
([bpmn-io#2231](bpmn-io#2231))
* `DEPS`: update to `bpmn-moddle@9`
([bpmn-io#2114](bpmn-io#2114))
* `DEPS`: update to `diagram-js@15.1.0`
* `DEPS`: update to `diagram-js-direct-editing@3.2.0`

### Breaking Changes

* Require `Node >= 20`
* `Canvas` is now a focusable element and provides better support for
native browser behaviors. Focus can be controlled with new `focus` and
`restoreFocus` APIs
([bpmn-io/diagram-js#662](bpmn-io/diagram-js#662)).
* Keyboard is now implicitly bound to canvas SVG element. Calls to
`keyboard.bind` and `keyboard.bindTo` now result with a descriptive
console error and have no effect
([bpmn-io/diagram-js#662](bpmn-io/diagram-js#662)).

## 17.11.1

* `FIX`: handle searching elements without labels
([bpmn-io#2232](bpmn-io#2232),
[bpmn-io#2234](bpmn-io#2234))

## 17.11.0

* `FEAT`: align search styles with other popups
([bpmn-io#2187](bpmn-io#2187))
* `FEAT`: prioritize start of tokens in search results
([bpmn-io#2187](bpmn-io#2187))
* `FIX`: do not commit viewport changes on `ESC`
([bpmn-io#2189](bpmn-io#2189),
[bpmn-io#2187](bpmn-io#2187))
* `DEPS`: update to `diagram-js@14.10.0`

## 17.10.0

* `CHORE`: correct various type hints
([bpmn-io#2228](bpmn-io#2228))
* `FIX`: pasting compensation activity without boundary event
([bpmn-io#2070](bpmn-io#2070))
* `FIX`: lane resize constraints for se and nw direction
([bpmn-io#2209](bpmn-io#2209))
* `FIX`: auto place elements vertically in sub-processes
([bpmn-io#2127](bpmn-io#2127))
* `FIX`: hide lane label during direct editing
* `DEPS`: update to `diagram-js@14.9.0`

## 17.9.2

* `FIX`: keep direction when collapsing pools
([bpmn-io#2208](bpmn-io#2208))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdul99ahad abdul99ahad

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pasting compensation activity bpmn-io/bpmn-js
3 participants
@nikku @philippfromme @abdul99ahad