fix: pasting compensation activity #2220
Conversation
bpmn-io-tasks
bot
added
in progress
abdul99ahad
force-pushed
the
2070-pasting-compensation-activity
branch
from
a4bf3f4 to
4bf491a
Compare
bpmn-io-tasks
bot
added
needs review
There was a problem hiding this comment.
It took me a while to understand why this fix is working. It turns out it only works because of CompensateBoundaryEventBehavior which adds isForCompensation when connecting a task to a compensation boundary event and the fact that during paste connections are created after shapes. So with your change in BpmnReplace isForCompensation is first removed and then added again only if CompensateBoundaryEventBehavior is present. This is not the right fix. Instead, as we discussed, we want to check after replace whether we need to remove isForCompensation . Try removing the change in BpmnReplace and instead check in BpmnRules not only whether the element is a compensation activity but also whether it is connected to a compensation boundary event. 😉
bpmn-io-tasks
bot
added
in progress
abdul99ahad
force-pushed
the
2070-pasting-compensation-activity
branch
from
4bf491a to
8511c2a
Compare
abdul99ahad
force-pushed
the
2070-pasting-compensation-activity
branch
from
9cb1bbd to
e6c8ff5
Compare
abdul99ahad
force-pushed
the
2070-pasting-compensation-activity
branch
from
6133944 to
9069333
Compare
|
|
||
| function isForCompensation(element) { | ||
| const bo = getBusinessObject(element); | ||
| return bo && typeof bo.get === 'function' && bo.get('isForCompensation'); |
There was a problem hiding this comment.
Not sure what we want to guard with `bo.get === 'function'.
If there is anything specific, let's create a test case. Otherwise, let's assume that the BO is always a moddle element (flowElement) and has a .get method.
There was a problem hiding this comment.
The issue was caused by some label elements that were breaking this function. I have updated the PR so that now only Task elements are checked for the compensation property.
There was a problem hiding this comment.
Cf. 61d9c02. The test case was broken. For bpmn-js, a business object must always exist.
Also, you don't have to rely on get, but check the property directly. This is what I changed.
There was a problem hiding this comment.
Please clarify #2220 (comment) before we can get this merged.
lib/features/modeling/behavior/SetCompensationActivityAfterPasteBehavior.js
Outdated
Show resolved
Hide resolved
abdul99ahad
force-pushed
the
2070-pasting-compensation-activity
branch
from
4009909 to
702904e
Compare
nikku
force-pushed
the
2070-pasting-compensation-activity
branch
from
702904e to
61d9c02
Compare
|
Squashed into single semantic commit, will go ahead and update CHANGELOG. |
nikku
force-pushed
the
2070-pasting-compensation-activity
branch
from
61d9c02 to
523cfb7
Compare
|
Waiting for CI to pass so we can merge this. |
Issue:
When copying and pasting a compensation activity the isForCompensation marker isn't being removed on paste. Since that marker is being added and removed automatically the expectation would be that it's removed on paste and only added once the activity is connected to a compensation boundary event.
Fix:
The compensation activity can only exist when connected with compensation boundary activity. When compensation activity is being pasted, it results in simple activity.
Closes #2070