Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new logger throughout code base #12

Closed
1 of 4 tasks
Radeonmann opened this issue Oct 12, 2021 · 2 comments
Closed
1 of 4 tasks

Use new logger throughout code base #12

Radeonmann opened this issue Oct 12, 2021 · 2 comments
Assignees
@Radeonmann
Labels
enhancement New feature or request
Milestone
v0.0.7

Comments

@Radeonmann
Copy link
Collaborator

Radeonmann commented Oct 12, 2021 •
edited
Loading

Currently there is a lot of code which fails without any log entry. Also at some places console.log was used for debugging. Other places use vscode.window.showXxxMessage. All existing code should be scanned and log entries should be done properly.

The new log API from #7 should be used everywhere.

  • Replace all console.log, console.warn, ...
  • Check all vscode.window.showXxxMessage and replace with logger if appropriate
  • Check where error and warning log entries should be done
  • Check where info and debug log entries should be done
@Radeonmann Radeonmann added the enhancement New feature or request label Oct 12, 2021
@Radeonmann Radeonmann self-assigned this Oct 12, 2021
Radeonmann added a commit that referenced this issue Oct 12, 2021
@Radeonmann
Added and replaced logger messages #12
73a956c
@Radeonmann Radeonmann added this to the v0.0.4 milestone Oct 28, 2021
@Radeonmann Radeonmann modified the milestones: v0.0.4, v0.0.5 Nov 30, 2021
Radeonmann added a commit that referenced this issue Jan 15, 2022
@Radeonmann
Replaced all console output with logger #12
39103b8
@Radeonmann
Copy link
Collaborator Author

All existing console log were replaced. Existing functionality without log will be adjusted on change of architecture (#5)

@Radeonmann Radeonmann modified the milestones: v0.0.5, v0.0.7 Jan 16, 2022
Radeonmann added a commit that referenced this issue Jan 25, 2022
@Radeonmann
Implemented new class based architecture for environment #5
75fe22d 
Before, the whol environment was in one file with local variables...

The new structure has classes and static classes which each represent a single environment component. This makes the code more flexible for new features and additions to single components.

At the same time some components now offer more flexibility for changes in file namings and diretcory structures.

The extension logger was used in all new components #12

The stray logger entry on startup is also gone now #28.
@Radeonmann
Copy link
Collaborator Author

Most places now use the new logging system, so the issue will be closed. Other missing logging / overlogging will be handled in separate issues when problems arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radeonmann Radeonmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.0.7
Development

No branches or pull requests
1 participant
@Radeonmann