Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Architectural change to classes #5

Closed
3 tasks
Radeonmann opened this issue Oct 18, 2020 · 0 comments
Closed
3 tasks

Architectural change to classes #5

Radeonmann opened this issue Oct 18, 2020 · 0 comments
Assignees
@Radeonmann
Labels
architecture Changes in basic architecture of existing code
Milestone
v0.0.7

Comments

@Radeonmann
Copy link
Collaborator

Radeonmann commented Oct 18, 2020 •
edited
Loading

Currently most of the functionality is implemented as functions and interfaces. As the functionality gets more complex, it is also required to use disposable objects from the VS Code API (e.g. FileSystemWatcher). To be able to properly dispose these ressources (e.g. on an update of the workspace projects) it will be better to also use more classes instead of interfaces or extend existing VS Code classes (e.g. Disposable) in the vscode-brautomationtools code base.

  • First all places where a change to classes will be better need to be identified

Following interfaces should be changed to classes or extend Disposable:

  • BRAsProjectWorkspace.AsProjectInfo
    Will require a
  • ...
@Radeonmann Radeonmann added the architecture Changes in basic architecture of existing code label Oct 18, 2020
@Radeonmann Radeonmann added this to the v0.0.6 milestone Dec 8, 2021
@Radeonmann Radeonmann self-assigned this Dec 8, 2021
Radeonmann added a commit that referenced this issue Dec 30, 2021
@Radeonmann
Changed interface to extension configuration to use class with getter…
0de04a6 
…s / setters #5
This was referenced Jan 16, 2022
Closed
Closed
Closed
@Radeonmann Radeonmann modified the milestones: v0.0.6, v0.0.7 Jan 17, 2022
Radeonmann added a commit that referenced this issue Jan 19, 2022
@Radeonmann
Moved environment code to new directory #5
2867566
Radeonmann added a commit that referenced this issue Jan 19, 2022
@Radeonmann
Created new classes for PVI environment infrastructure #5
e21c443
Radeonmann added a commit that referenced this issue Jan 25, 2022
@Radeonmann
Renamed Pvi #5
7c8d82b
Radeonmann added a commit that referenced this issue Jan 25, 2022
@Radeonmann
Added classes to represent gcc #5
02d84fe
Radeonmann added a commit that referenced this issue Jan 25, 2022
@Radeonmann
Implemented new class based architecture for environment #5
75fe22d 
Before, the whol environment was in one file with local variables...

The new structure has classes and static classes which each represent a single environment component. This makes the code more flexible for new features and additions to single components.

At the same time some components now offer more flexibility for changes in file namings and diretcory structures.

The extension logger was used in all new components #12

The stray logger entry on startup is also gone now #28.
Radeonmann added a commit that referenced this issue Apr 24, 2022
@Radeonmann
Implemented classes for various package files #5
6789775
Radeonmann added a commit that referenced this issue Apr 24, 2022
@Radeonmann
Added class for user settings file #5
ad9b76f
Radeonmann added a commit that referenced this issue Apr 24, 2022
@Radeonmann
Added template for file classes #5
6edd250
Radeonmann added a commit that referenced this issue Apr 24, 2022
@Radeonmann
Added and used class for a hardware configuration #5
db0bccd
Radeonmann added a commit that referenced this issue Jun 11, 2022
@Radeonmann
Comments and minor code cleanup of workspace file classes #5
6c2b365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Radeonmann Radeonmann

Labels
architecture Changes in basic architecture of existing code
Projects
None yet
Milestone
v0.0.7
Development

No branches or pull requests
1 participant
@Radeonmann