do not patch druntime/phobos win64.mak#10
Closed
rainers wants to merge 1 commit intobraddr:masterfrom
Closed
Conversation
This was referenced Jan 4, 2019
Contributor
|
See also: #8 |
Contributor
|
Ping @braddr. Any chance to get this deployed? |
braddr
added a commit
that referenced
this pull request
Mar 4, 2019
Author
|
Closing as a similar patch has been committet. Thanks @braddr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adopted from how I build the Win64 druntime/phobos libraries for years.
Recently I noticed that having spaces in path names doesn't really work, cleaned it up in dlang/phobos#6825 and dlang/druntime#2438, but these are blocked by the auto-tester patching.
AFAICT you have installed VS to d:\vs2013 avoiding spaces, so there should not be a problem with both versions.
The diff for dmd can also be removed by just using gmake explicitly in dmd/win32.mak, but that probably needs some transition that doesn't break any of the various branches.