Skip to content

fix quoting in win64.mak: add them only when invoking command#6825

Merged
dlang-bot merged 1 commit intodlang:masterfrom
rainers:win64_mak_quote
Mar 5, 2019
Merged

fix quoting in win64.mak: add them only when invoking command#6825
dlang-bot merged 1 commit intodlang:masterfrom
rainers:win64_mak_quote

Conversation

@rainers
Copy link
Member

@rainers rainers commented Jan 3, 2019

not when setting variable. This avoids having to skillfully quote variables with spaces in them: use "CC=%cl64%" instead of "CC=\"%cl64%\""

Not sure how the existing misquoting was supposed to work. Using quotes with the command is agnostic to using / instead of \ as a path separator, too.

See also dlang/druntime#2438

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6825"

@rainers rainers changed the title fix quoting in wn64.mak: add them only when invoking command fix quoting in win64.mak: add them only when invoking command Jan 3, 2019
@rainers
Copy link
Member Author

rainers commented Jan 3, 2019

Now also quoting $(MAKE)

@PetarKirov
Copy link
Member

It looks like https://github.com/braddr/at-client/blob/master/src/diff-phobos-win64.diff needs to be updated. Or even better - removed entirely ;)

@wilzbach
Copy link
Contributor

wilzbach commented Jan 3, 2019

CC @braddr

@rainers
Copy link
Member Author

rainers commented Jan 4, 2019

Or even better - removed entirely ;)

braddr/at-client#10

@rainers
Copy link
Member Author

rainers commented Mar 5, 2019

With the diffs removed from the autotester, this should be unblocked.

@kinke
Copy link
Contributor

kinke commented Mar 5, 2019

This avoids having to skillfully quote variables

Lol, one way to put it. ;)

@wilzbach
Copy link
Contributor

wilzbach commented Mar 5, 2019

Looks like the patching is still done by the Auto-Tester:

https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3546293&isPull=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments