fix quoting in win64.mak: add them only when invoking command#6825
fix quoting in win64.mak: add them only when invoking command#6825dlang-bot merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6825" |
…n setting variable
b7d8feb to
acb5732
Compare
|
Now also quoting $(MAKE) |
|
It looks like https://github.com/braddr/at-client/blob/master/src/diff-phobos-win64.diff needs to be updated. Or even better - removed entirely ;) |
|
CC @braddr |
|
|
With the diffs removed from the autotester, this should be unblocked. |
Lol, one way to put it. ;) |
|
Looks like the patching is still done by the Auto-Tester: https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3546293&isPull=true |
not when setting variable. This avoids having to skillfully quote variables with spaces in them: use
"CC=%cl64%"instead of"CC=\"%cl64%\""Not sure how the existing misquoting was supposed to work. Using quotes with the command is agnostic to using
/instead of\as a path separator, too.See also dlang/druntime#2438