Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] fix masculine and feminine forms of the weekdays in PT #326

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

einavkor
Copy link
Contributor

Hello! This pull request addresses a grammatical issue in the Portuguese translation of weekdays and weekends.

In Portuguese, weekdays are grammatically feminine, while weekends are masculine. Currently, the output does not reflect this distinction, leading to incorrect gender usage in some translations.

Example
Given the following cron expression:

45 10 * * 6#2
(At 10:45 AM, on the second Saturday of the month)

Expected Output:
"Às 10:45, no segundo sábado do mês"

Actual Output:
"Às 10:45, na segunda sábado do mês"

This PR corrects the gender agreement for weekend days, ensuring accurate and grammatically correct translations.

Thank you for your consideration!

@einavkor
Copy link
Contributor Author

@bradymholt

Copy link
Owner

@bradymholt bradymholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@bradymholt bradymholt merged commit cd9f742 into bradymholt:main Oct 28, 2024
2 checks passed
Copy link

The changes in this PR were just released in v2.51.0 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants