Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed default audio type for windows #1004

Merged
merged 5 commits into from
Nov 17, 2023
Merged

fix: changed default audio type for windows #1004

merged 5 commits into from
Nov 17, 2023

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Nov 14, 2023 •
edited
Loading

This PR changes send_audio_type in discordvoiceclient.h to be satype_overlap_audio if on windows. This should make issues like #978 hopefully appear less, if not at all.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2023 •
edited
Loading

✅ Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 9fb93b5
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/65537222ef165800081982e6
😎 Deploy Preview https://deploy-preview-1004--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Nov 14, 2023
@Jaskowicz1 Jaskowicz1 mentioned this pull request Nov 14, 2023
Closed
@Jaskowicz1 Jaskowicz1 self-assigned this Nov 17, 2023
@Jaskowicz1 Jaskowicz1 merged commit fcd23e6 into brainboxdotcc:dev Nov 17, 2023
34 checks passed
@Jaskowicz1 Jaskowicz1 deleted the audio-type-changes branch November 17, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

@craigpipeandpiper craigpipeandpiper Awaiting requested review from craigpipeandpiper

Assignees

@Jaskowicz1 Jaskowicz1

Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jaskowicz1 @braindigitalis @craigpipeandpiper