Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed default audio type for windows #1004

Merged
merged 5 commits into from
Nov 17, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions include/dpp/discordvoiceclient.h
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,10 @@ class DPP_EXPORT discord_voice_client : public websocket_client
snowflake channel_id;

/**
* @brief The audio type to be sent. The default type is recorded audio.
* @brief The audio type to be sent.
*
* @note On Windows, the default type is overlap audio.
* On all other platforms, it is recorded audio.
*
* If the audio is recorded, the sending of audio packets is throttled.
* Otherwise, if the audio is live, the sending is not throttled.
Expand Down Expand Up @@ -594,10 +597,15 @@ class DPP_EXPORT discord_voice_client : public websocket_client
*/
enum send_audio_type_t
{
satype_recorded_audio,
satype_live_audio,
satype_recorded_audio,
satype_live_audio,
satype_overlap_audio
} send_audio_type = satype_recorded_audio;
} send_audio_type =
#ifdef _WIN32
satype_overlap_audio;
#else
satype_recorded_audio;
#endif

/**
* @brief Sets the gain for the specified user.
Expand Down