Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the markers to disable specific slowly running tests #348

Merged
merged 7 commits into from
May 17, 2024

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented May 14, 2024

All tests will either run "normally", or have been disabled if the functionality is broken (see #347).

Developed on top of #346 so that should be merged first. Tests will fail until the new version of brainglobe-utils is released.

Closes #285

Docs updated here: brainglobe/brainglobe.github.io#185

pyproject.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.13%. Comparing base (004e84d) to head (c31da8a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   86.47%   87.13%   +0.65%     
==========================================
  Files          27       27              
  Lines        1220     1220              
==========================================
+ Hits         1055     1063       +8     
+ Misses        165      157       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson
Copy link
Member Author

@alessandrofelder I've finally managed to get the tests to pass 🎉

For some reason pooch was returning a list of paths that was in a different order on CI vs locally 🤷

@adamltyson
Copy link
Member Author

adamltyson commented May 16, 2024

Windows tests seem to be taking a long time, but that may be some temporary issue with GH actions. If it persists I'll look into it.

@alessandrofelder alessandrofelder merged commit 2e10fab into main May 17, 2024
13 checks passed
@alessandrofelder alessandrofelder deleted the slow-tests branch May 17, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] improve testing set-up
2 participants