This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Removes youtube channel rule #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/browser-laptop#13217
Problem with this rule is that when you land on page like https://www.youtube.com/channel/UCd534c_ehOvrLVL2v7Nl61w this page is categorised as video where it should be a simple
youtube.com. We only categorized videos as youtube publishers not sites.If we want to change this, then this PR can be ignored and we need to adjust multiple things to work correctly. Benefit of adjusting it is that verified check can be displayed for youtube channels that are verified. Down side is that we would need to make sure that same ID is always used, so that we would not create duplicates like channel name vs channel ID