Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

seeing youtube#channel:{channelId} in the about:preferences#payments panel #13217

Closed
mrose17 opened this issue Feb 21, 2018 · 12 comments
Closed

seeing youtube#channel:{channelId} in the about:preferences#payments panel #13217

mrose17 opened this issue Feb 21, 2018 · 12 comments
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x Release 3 ...

Comments

@mrose17
Copy link
Member

mrose17 commented Feb 21, 2018 •
edited by NejcZdovc
Loading

i don't have a STR, but i am still seeing this.

until we get a STR, can we at least have some code that runs when the panel becomes active to look for entries like this and resolve them back to reality, e.g., the underlying URL should be https://www.youtube.com/channel:UCQg4kOKdfzvsxHX4IjSzqTw instead of https://youtube/#channel:UCQg4kOKdfzvsxHX4IjSzqTw and perhaps we can get the actual name of the channel?

0

STR

  1. enable payments
  2. go to https://www.youtube.com/channel/UCd534c_ehOvrLVL2v7Nl61w or https://www.youtube.com/channel/UCtinbF-Q-fVthA0qrFQTgXQ
  3. watch video
@NejcZdovc NejcZdovc self-assigned this Feb 21, 2018
@arsalankhalid
Copy link
Contributor

Happy to take this @NejcZdovc is it open?

@NejcZdovc
Copy link
Contributor

@arsalankhalid yeah but we don't have STR

@mrose17
Copy link
Member Author

mrose17 commented Mar 7, 2018

we don't have a STR but i get it a lot. stop by later today and i'll show you what i see and maybe you an figure it out @arsalankhalid - thanks!

@mrose17
Copy link
Member Author

mrose17 commented Mar 7, 2018

at the very least we can put in a fix when it does happen...

@arsalankhalid
Copy link
Contributor

Just caught up with this, happy to do that :) I don't believe I can easily stop by though, since I'm in Toronto. Luckily we can e-meet! I believe you guys use zoom, should we briefly chat there or on Discord?

@NejcZdovc NejcZdovc removed their assignment Apr 10, 2018
@NejcZdovc NejcZdovc self-assigned this Apr 17, 2018
@jasonrsadler
Copy link
Contributor

@mrose17 @NejcZdovc Current live release shows that we are getting channel names. Do we have an STR on this yet?

@jasonrsadler jasonrsadler added the needs-info Another team member needs information from the PR/issue opener. label Apr 25, 2018
@jasonrsadler jasonrsadler self-assigned this Apr 25, 2018
@mrose17
Copy link
Member Author

mrose17 commented Apr 25, 2018

there is no STR. however, it happens to me several times a day.

@NejcZdovc
Copy link
Contributor

I manage to reproduce it and I have STR

@NejcZdovc NejcZdovc removed the needs-info Another team member needs information from the PR/issue opener. label Apr 26, 2018
@NejcZdovc
Copy link
Contributor

hmm can't reproduce it anymore :S

@NejcZdovc
Copy link
Contributor

problem found, doing PR

@NejcZdovc
Copy link
Contributor

will be fixed with this PR brave-intl/bat-client#59

@NejcZdovc NejcZdovc mentioned this issue Apr 26, 2018
Merged
@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone Apr 26, 2018
@NejcZdovc NejcZdovc reopened this Apr 26, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 26, 2018
@NejcZdovc
Bat-client version bump
6b4d509 
Fixes brave#13217
Fixes brave#13875

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Apr 26, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Apr 26, 2018
@NejcZdovc
Bat-client version bump
1fccba5 
Fixes brave#13217
Fixes brave#13875

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Apr 26, 2018
@NejcZdovc
Merge pull request #13951 from NejcZdovc/fix/#13217-bump
ab99357 
Bat-client version bump
NejcZdovc added a commit that referenced this issue Apr 26, 2018
@NejcZdovc
Merge pull request #13951 from NejcZdovc/fix/#13217-bump
f33c1c5 
Bat-client version bump
NejcZdovc added a commit that referenced this issue Apr 26, 2018
@NejcZdovc
Merge pull request #13951 from NejcZdovc/fix/#13217-bump
99207d1 
Bat-client version bump
This was referenced May 3, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented May 3, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.702 e4a853d
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

Verified with the two publishers mentioned in original issue. Shows correct name.

Verified with macOS 10.12.6 using

  • 0.22.702 e4a853d
  • muon 6.0.7
  • libchromiumcontent 66.0.3359.139

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

@srirambv srirambv mentioned this issue May 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
8 participants
@mrose17 @bsclifton @arsalankhalid @NejcZdovc @srirambv @jasonrsadler @LaurenWags @btlechowski