Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bat-client version bump #13951

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Bat-client version bump #13951

merged 1 commit into from
Apr 26, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 26, 2018

Fixes #13217
Fixes #13875

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

  1. enable payments
  2. go to https://www.youtube.com/channel/UCd534c_ehOvrLVL2v7Nl61w or https://www.youtube.com/channel/UCtinbF-Q-fVthA0qrFQTgXQ
  3. watch video on this site
  4. make sure that there is no strange entries in ledger table

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.22.x Release 3 (Beta channel) milestone Apr 26, 2018
@NejcZdovc NejcZdovc self-assigned this Apr 26, 2018
Fixes brave#13217
Fixes brave#13875

Auditors:

Test Plan:
Copy link
Member

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR.

@NejcZdovc NejcZdovc merged commit ab99357 into brave:master Apr 26, 2018
NejcZdovc added a commit that referenced this pull request Apr 26, 2018
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Apr 26, 2018

master ab99357
0.23 f33c1c5
0.22 99207d1

@codecov-io
Copy link

codecov-io commented Apr 26, 2018

Codecov Report

Merging #13951 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13951      +/-   ##
==========================================
- Coverage   56.45%   56.42%   -0.04%     
==========================================
  Files         284      284              
  Lines       29220    29220              
  Branches     4851     4851              
==========================================
- Hits        16495    16486       -9     
- Misses      12725    12734       +9
Flag Coverage Δ
#unittest 56.42% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.66% <0%> (-8.34%) ⬇️
app/renderer/components/reduxComponent.js 57.75% <0%> (-3.45%) ⬇️
js/stores/windowStore.js 28.46% <0%> (-0.3%) ⬇️

NejcZdovc added a commit that referenced this pull request Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants