Skip to content
This repository has been archived by the owner on Jun 6, 2019. It is now read-only.

Adds support for batch voting #74

Merged
merged 3 commits into from
May 23, 2018
Merged

Adds support for batch voting #74

merged 3 commits into from
May 23, 2018

Conversation

NejcZdovc
Copy link
Contributor

Resolves #65

@NejcZdovc NejcZdovc self-assigned this May 11, 2018
@NejcZdovc NejcZdovc force-pushed the 65-batch branch 2 times, most recently from ed6b24e to a26d608 Compare May 17, 2018 07:43
@NejcZdovc NejcZdovc force-pushed the 65-batch branch 2 times, most recently from f298218 to ea0675b Compare May 21, 2018 05:28
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented May 21, 2018 •
edited
Loading

@evq @mrose17 currently getting 404 for

[ response for PUT https://ledger-staging.mercury.basicattentiontoken.org/v2/batch/surveyor/voting ]

@NejcZdovc
Copy link
Contributor Author

it's POST and not PUT, thx @evq

@NejcZdovc NejcZdovc force-pushed the 65-batch branch 3 times, most recently from 7245d11 to 5270c89 Compare May 21, 2018 06:48
@NejcZdovc
Copy link
Contributor Author

This PR will addresses issue in brave/browser-laptop#14190

@NejcZdovc NejcZdovc requested a review from mrose17 May 21, 2018 06:52
@jasonrsadler
Copy link
Contributor

jasonrsadler commented May 22, 2018 •
edited
Loading

@NejcZdovc Can you rebase? My tests merge caused a conflict here in package.json.

@NejcZdovc NejcZdovc force-pushed the 65-batch branch 3 times, most recently from 25fbee5 to 122e6d4 Compare May 22, 2018 11:21
mrose17
mrose17 suggested changes May 22, 2018
View reviewed changes
Copy link
Contributor

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really hate to ask this, but can we have just one test that verifies that batches are grouped properly...

@NejcZdovc
Copy link
Contributor Author

@mrose17 sure not a problem

@jasonrsadler jasonrsadler mentioned this pull request May 22, 2018
Merged
10 tasks
@NejcZdovc
Copy link
Contributor Author

@mrose17 tests added for batch preparation

@NejcZdovc NejcZdovc requested a review from mrose17 May 23, 2018 06:31
mrose17
mrose17 approved these changes May 23, 2018
View reviewed changes
Copy link
Contributor

@mrose17 mrose17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 8c703be into brave-intl:master May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrose17 mrose17 mrose17 approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
PR/pending-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @jasonrsadler @mrose17