Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add support for batch voting #14190

Closed
NejcZdovc opened this issue May 21, 2018 · 1 comment
Closed

Add support for batch voting #14190

NejcZdovc opened this issue May 21, 2018 · 1 comment
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x Release 5 ...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented May 21, 2018 •
edited
Loading

Description

Test plan

  • enable payments
  • add some publishers
  • make contribution
  • make sure that contribution is done and that PDF is generated

Currently we are sending every vote as a single request. Let's batch this requests into one.
@NejcZdovc NejcZdovc self-assigned this May 21, 2018
@NejcZdovc NejcZdovc mentioned this issue May 21, 2018
Merged
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 21, 2018
@NejcZdovc
Adds batch voting
39d5b82 
Resolves brave#14190

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue May 21, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc added this to the 0.22.x Release 5 milestone May 22, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 24, 2018
@NejcZdovc
Adds batch voting
b9fafc3 
Resolves brave#14190

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue May 24, 2018
@NejcZdovc
Adds batch voting
f0dffef 
Resolves brave#14190

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue May 24, 2018
@NejcZdovc
Merge pull request #14191 from NejcZdovc/feature/#14190-batch
4d3cd36 
Adds batch voting
NejcZdovc added a commit that referenced this issue May 24, 2018
@NejcZdovc
Merge pull request #14191 from NejcZdovc/feature/#14190-batch
6fbcba7 
Adds batch voting
NejcZdovc added a commit that referenced this issue May 24, 2018
@NejcZdovc
Merge pull request #14191 from NejcZdovc/feature/#14190-batch
204b90b 
Adds batch voting
NejcZdovc added a commit that referenced this issue May 25, 2018
@NejcZdovc
Merge pull request #14191 from NejcZdovc/feature/#14190-batch
2608c7a 
Adds batch voting
@btlechowski
Copy link
Contributor

btlechowski commented May 29, 2018 •
edited by srirambv
Loading

Verified on Ubuntu 17.10 x64. Made the contribution on staging.

  • 0.22.722 1dde2a2
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified with macOS 10.12.6 using staging (but not UGP BAT) on this build:

  • 0.22.723 edb3e88
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

Verified on Windows x64 using

  • 0.22.725 e6dd17f
  • muon 6.0.12
  • libchromiumcontent 66.0.3359.170

This was referenced May 30, 2018
Closed
Closed
This was referenced May 31, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jun 1, 2018
Closed
17 tasks
@kjozwiak kjozwiak mentioned this issue Jun 4, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x Release 5 (Release channel)
Development

No branches or pull requests
4 participants
@NejcZdovc @srirambv @LaurenWags @btlechowski